Re: [PATCH] scsi_host sysfs updates scsi-misc-2.5 [2/2]

Mike Anderson
2003-05-09T07:36:14Z

Christoph Hellwig [hch@infradead.org] wrote:
> On Thu, May 08, 2003 at 11:35:45PM -0700, Mike Anderson wrote:
> > --- sysfs-scsi-misc-2.5/drivers/scsi/hosts.h~scsi_shost_sysfs-misc-fix Thu May 8 22:46:53 2003
> > +++ sysfs-scsi-misc-2.5-andmike/drivers/scsi/hosts.h Thu May 8 22:46:53 2003
> > @@ -556,6 +556,7 @@ extern int scsi_unregister_device(struct
> > */
> > extern struct Scsi_Host * scsi_register(Scsi_Host_Template *, int);
> > extern void scsi_unregister(struct Scsi_Host *);
> > +extern void scsi_free_shost(struct Scsi_Host *);
>
> This should go into scsi_priv.h
>

Ok I will move this and resend to James.

> >
> > /*
> > * HBA registration/unregistration.
> > @@ -570,6 +571,7 @@ extern int scsi_register_host(Scsi_Host_
> > extern int scsi_unregister_host(Scsi_Host_Template *);
> >
> > extern struct Scsi_Host *scsi_host_hn_get(unsigned short);
> > +extern void scsi_host_get(struct Scsi_Host *);
> > extern void scsi_host_put(struct Scsi_Host *);
>
> This should go either into scsi_priv.h or exported if we see
> a use for it in driver (I'd rather avoid drivers messing with
> reference counts, though)
>

I think it should go into scsi_priv.h. I thought it would be good to have
a symmetric interface, but would worry about drivers messing with the
counts if it was exported.

Note: scsi_host_get_next and scsi_host_hn_get need ref counting, but
I wanted to look at this a bit and see if we could utilize some
sysfs interfaces.