Re: [PATCH] scsi_host sysfs updates scsi-misc-2.5 [0/2]

Patrick Mochel
2003-05-13T23:47:19Z

On Mon, 12 May 2003, Mike Anderson wrote:

> James Bottomley [James.Bottomley@steeleye.com] wrote:
> > On Mon, 2003-05-12 at 12:50, James Bottomley wrote:
> > > Surprisingly, it still fails. I've debugged the refcounting and I see
> > > it fall to zero in scsi_host_put but the dev release method doesn't
> > > trigger for no reason I can see.
> > >
> > > It's probably a kobject initialisation problem somewhere.
> >
> > OK, found it. the ->release is triggered by the kobj_kset, which isn't
> > set until device_add time, not device init time.
> >
> > Therefore, we shouldn't really put and get objects until they've been
> > added (or the kobj_set_kset_s needs to be moved to device_initialize()).
> >
>
> I would like to have feedback from Mochel on the device_initialize
> call.

Just to set the record straight - James suggested this on irc yesterday,
and I've added it to my tree. I haven't seen any issues with it, and based
on later emails, you've worked out the slab issue. So, it'll be pushed to
Linus.

-pat