Re: [PATCH] scsi_host sysfs updates scsi-misc-2.5 [2/2]

Christoph Hellwig
2003-05-09T06:47:09Z

On Thu, May 08, 2003 at 11:35:45PM -0700, Mike Anderson wrote:
> --- sysfs-scsi-misc-2.5/drivers/scsi/hosts.h~scsi_shost_sysfs-misc-fix Thu May 8 22:46:53 2003
> +++ sysfs-scsi-misc-2.5-andmike/drivers/scsi/hosts.h Thu May 8 22:46:53 2003
> @@ -556,6 +556,7 @@ extern int scsi_unregister_device(struct
> */
> extern struct Scsi_Host * scsi_register(Scsi_Host_Template *, int);
> extern void scsi_unregister(struct Scsi_Host *);
> +extern void scsi_free_shost(struct Scsi_Host *);

This should go into scsi_priv.h

>
> /*
> * HBA registration/unregistration.
> @@ -570,6 +571,7 @@ extern int scsi_register_host(Scsi_Host_
> extern int scsi_unregister_host(Scsi_Host_Template *);
>
> extern struct Scsi_Host *scsi_host_hn_get(unsigned short);
> +extern void scsi_host_get(struct Scsi_Host *);
> extern void scsi_host_put(struct Scsi_Host *);

This should go either into scsi_priv.h or exported if we see
a use for it in driver (I'd rather avoid drivers messing with
reference counts, though)

Patch looks fine otherwise.