public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_host sysfs updates scsi-misc-2.5 [2/2]
Date: Fri, 9 May 2003 07:59:46 +0100	[thread overview]
Message-ID: <20030509075946.A10204@infradead.org> (raw)
In-Reply-To: <20030509063545.GC3259@beaverton.ibm.com>; from andmike@us.ibm.com on Thu, May 08, 2003 at 11:35:45PM -0700

On Thu, May 08, 2003 at 11:35:45PM -0700, Mike Anderson wrote:
> --- sysfs-scsi-misc-2.5/drivers/scsi/hosts.h~scsi_shost_sysfs-misc-fix	Thu May  8 22:46:53 2003
> +++ sysfs-scsi-misc-2.5-andmike/drivers/scsi/hosts.h	Thu May  8 22:46:53 2003
> @@ -556,6 +556,7 @@ extern int scsi_unregister_device(struct
>   */
>  extern struct Scsi_Host * scsi_register(Scsi_Host_Template *, int);
>  extern void scsi_unregister(struct Scsi_Host *);
> +extern void scsi_free_shost(struct Scsi_Host *);

This should go into scsi_priv.h

>  
>  /*
>   * HBA registration/unregistration.
> @@ -570,6 +571,7 @@ extern int scsi_register_host(Scsi_Host_
>  extern int scsi_unregister_host(Scsi_Host_Template *);
>  
>  extern struct Scsi_Host *scsi_host_hn_get(unsigned short);
> +extern void scsi_host_get(struct Scsi_Host *);
>  extern void scsi_host_put(struct Scsi_Host *);

This should go either into scsi_priv.h or exported if we see
a use for it in driver (I'd rather avoid drivers messing with
reference counts, though)

Patch looks fine otherwise.

  reply	other threads:[~2003-05-09  6:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-09  6:33 [PATCH] scsi_host sysfs updates scsi-misc-2.5 [0/2] Mike Anderson
2003-05-09  6:34 ` [PATCH] scsi_host sysfs updates scsi-misc-2.5 [1/2] Mike Anderson
2003-05-09  6:35   ` [PATCH] scsi_host sysfs updates scsi-misc-2.5 [2/2] Mike Anderson
2003-05-09  6:59     ` Christoph Hellwig [this message]
2003-05-09  7:50       ` Mike Anderson
2003-05-09  8:21         ` Mike Anderson
2003-05-12  3:57 ` [PATCH] scsi_host sysfs updates scsi-misc-2.5 [0/2] James Bottomley
2003-05-12  6:38   ` Mike Anderson
2003-05-12 17:50     ` James Bottomley
2003-05-12 17:59       ` James Bottomley
2003-05-12 18:41         ` Mike Anderson
2003-05-12 20:10           ` James Bottomley
2003-05-12 20:35             ` Mike Anderson
2003-05-12 20:42               ` James Bottomley
2003-05-12 20:53                 ` James Bottomley
2003-05-12 21:49                 ` Mike Anderson
2003-05-12 21:50                   ` James Bottomley
2003-05-12 22:15                     ` Mike Anderson
2003-05-14  0:00           ` Patrick Mochel
2003-05-12 18:18       ` Mike Anderson
2003-05-12 15:15 ` Andrew Vasquez
2003-05-13 18:51   ` Mike Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030509075946.A10204@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox