From: Mike Anderson <andmike@us.ibm.com>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>, mochel@osdl.org
Subject: Re: [PATCH] scsi_host sysfs updates scsi-misc-2.5 [0/2]
Date: Mon, 12 May 2003 15:15:10 -0700 [thread overview]
Message-ID: <20030512221510.GE3226@beaverton.ibm.com> (raw)
In-Reply-To: <1052776222.3600.9.camel@mulgrave>
James Bottomley [James.Bottomley@steeleye.com] wrote:
> On Mon, 2003-05-12 at 16:49, Mike Anderson wrote:
> > I am seeing size-512 with my modified version of scsi_debug. I modified
> > slab.c to store last user for this size and it indicates it was
> > scsi_free_shost. I am looking at this now.
>
> I found it: you have a use after free in the sysfs code:
>
> scsi_host_put does put_device followed by class_device_put, but the
> put_device will free the shost containing the class_device in it's
> release, so the class_device_put touches a freed object.
>
> The solution is just to reverse the order of the puts.
Thanks for finding this. This fixes my slab issue also.
-andmike
--
Michael Anderson
andmike@us.ibm.com
next prev parent reply other threads:[~2003-05-12 22:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-09 6:33 [PATCH] scsi_host sysfs updates scsi-misc-2.5 [0/2] Mike Anderson
2003-05-09 6:34 ` [PATCH] scsi_host sysfs updates scsi-misc-2.5 [1/2] Mike Anderson
2003-05-09 6:35 ` [PATCH] scsi_host sysfs updates scsi-misc-2.5 [2/2] Mike Anderson
2003-05-09 6:59 ` Christoph Hellwig
2003-05-09 7:50 ` Mike Anderson
2003-05-09 8:21 ` Mike Anderson
2003-05-12 3:57 ` [PATCH] scsi_host sysfs updates scsi-misc-2.5 [0/2] James Bottomley
2003-05-12 6:38 ` Mike Anderson
2003-05-12 17:50 ` James Bottomley
2003-05-12 17:59 ` James Bottomley
2003-05-12 18:41 ` Mike Anderson
2003-05-12 20:10 ` James Bottomley
2003-05-12 20:35 ` Mike Anderson
2003-05-12 20:42 ` James Bottomley
2003-05-12 20:53 ` James Bottomley
2003-05-12 21:49 ` Mike Anderson
2003-05-12 21:50 ` James Bottomley
2003-05-12 22:15 ` Mike Anderson [this message]
2003-05-14 0:00 ` Patrick Mochel
2003-05-12 18:18 ` Mike Anderson
2003-05-12 15:15 ` Andrew Vasquez
2003-05-13 18:51 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030512221510.GE3226@beaverton.ibm.com \
--to=andmike@us.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox