From: Anton Blanchard <anton@samba.org>
To: Andrew Vasquez <praka@san.rr.com>, linux-scsi@vger.kernel.org
Subject: Re: [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b2).
Date: Fri, 30 May 2003 01:33:37 +1000 [thread overview]
Message-ID: <20030529153336.GA1027@krispykreme> (raw)
In-Reply-To: <20030529061913.GA27199@praka.local.home>
> > > + mmapbase &= PCI_BASE_ADDRESS_MEM_MASK;
> > > +
> > > + /* Find proper memory chunk for memory map I/O reg */
> > > + base = mmapbase & PAGE_MASK;
> > > + page_offset = mmapbase - base;
> >
> > Is that correct?
> >
I was more interested in the next bit, shouldnt base be
mmapbase & ~PAGE_MASK? Based on your next question it can go away
anyway.
> Is it safe to assume *all* platforms will handle this case internally,
> or should drivers perform the pre-process?
Yes, ioremap should handle non page aligned addresses.
Anton
prev parent reply other threads:[~2003-05-29 15:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-19 22:57 [ANNOUNCE] QLogic qla2xxx driver update available (v8.00.00b2) Andrew Vasquez
2003-05-21 17:32 ` Andrew Vasquez
2003-05-21 22:26 ` Anton Blanchard
2003-05-29 6:19 ` Andrew Vasquez
2003-05-29 14:26 ` Jeff Garzik
2003-05-29 15:17 ` Andrew Vasquez
2003-05-29 15:33 ` Anton Blanchard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030529153336.GA1027@krispykreme \
--to=anton@samba.org \
--cc=linux-scsi@vger.kernel.org \
--cc=praka@san.rr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox