Re: [PATCH] convert scsi core to use module_param interfaces

[Patrick Mansfield <patmans@us.ibm.com>]

On Fri, Jun 06, 2003 at 07:37:32AM +0100, Christoph Hellwig wrote:
> I don't think we can just change the name of the scsi core module -
> to much userspace stuff is relying on that.  Changing the prefix would
> be nice but I have no idea how we can do that.

Is it that bad? 

Do all distros that build with scsi build it into the kernel by default?

The only option (ignoring logging) we have in 2.4 is max_scsi_luns,
changing its name from max_scsi_luns to max_luns means users already have
to modify their modules.conf. For boot command line, users have to change
to scsi[_mod].whatever no matter what.

If not changing the module name:

Rusty had suggested undef/define KBUILD_MODNAME, that might not be very
nice for use across files, and/or we could get a patch into moduleparam.h
that gives a cleaner define name.

But it is cleaner to have the modprobe name option look like the boot
command line, i.e.:

	modprobe scsi max_luns=1

	scsi.max_luns=1

> We should also kill the scsi substrings in the individual options now
> that we have a regular prefix, I'll submit a patch.

The patch looks good.

-- Patrick Mansfield