Re: [PATCH] kill of ->command

[Matthew Dharm <mdharm-scsi@one-eyed-alien.net>]

[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]

On Mon, Jun 09, 2003 at 06:20:56PM +0200, Christoph Hellwig wrote:
> diff -Nru a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
> --- a/drivers/usb/storage/scsiglue.c	Sun Jun  8 20:31:57 2003
> +++ b/drivers/usb/storage/scsiglue.c	Sun Jun  8 20:31:57 2003
> @@ -365,24 +365,15 @@
>  	.name =				"usb-storage",
>  	.proc_name =			"usb-storage",
>  	.proc_info =			usb_storage_proc_info,
> -	.proc_dir =			NULL,
>  	.info =				usb_storage_info,
> -	.ioctl =			NULL,
> -
> -	/* old-style detect and release */
> -	.detect =			NULL,
> -	.release =			NULL,
>  
>  	/* command interface -- queued only */
> -	.command =			NULL,
>  	.queuecommand =			usb_storage_queuecommand,
>  
>  	/* error and abort handlers */
>  	.eh_abort_handler =		usb_storage_command_abort,
>  	.eh_device_reset_handler =	usb_storage_device_reset,
>  	.eh_bus_reset_handler =		usb_storage_bus_reset,
> -	.eh_host_reset_handler =	NULL,
> -	.eh_strategy_handler =		NULL,
>  
>  	/* queue commands only, only one command per LUN */
>  	.can_queue =			1,
> @@ -391,21 +382,9 @@
>  	/* unknown initiator id */
>  	.this_id =			-1,
>  
> -	/* no limit on commands */
> -	.max_sectors =			0,
> -	
> -	/* pre- and post- device scan functions */
> -	.slave_alloc =			NULL,
> -	.slave_configure =		NULL,
> -	.slave_destroy =		NULL,
> -
>  	/* lots of sg segments can be handled */
>  	.sg_tablesize =			SG_ALL,
>  
> -	/* use 32-bit address space for DMA */
> -	.unchecked_isa_dma =		FALSE,
> -	.highmem_io =			FALSE,
> -
>  	/* merge commands... this seems to help performance, but
>  	 * periodically someone should test to see which setting is more
>  	 * optimal.
> @@ -414,9 +393,6 @@
>  
>  	/* emulated HBA */
>  	.emulated =			TRUE,
> -
> -	/* sorry, no BIOS to help us */
> -	.bios_param =			NULL,
>  
>  	/* module management */
>  	.module =			THIS_MODULE

Could you please not kill all these fields?  If you want to remove command,
go ahead, but leave the others.

Matt

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

I'm a pink gumdrop! How can anything be worse?!!
					-- Erwin
User Friendly, 10/4/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]