From: Matthew Dharm <mdharm-scsi@one-eyed-alien.net>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Christoph Hellwig <hch@lst.de>,
James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] kill of ->command
Date: Mon, 9 Jun 2003 11:45:15 -0700 [thread overview]
Message-ID: <20030609114515.D5618@one-eyed-alien.net> (raw)
In-Reply-To: <20030609183715.GB20308@gtf.org>; from jgarzik@pobox.com on Mon, Jun 09, 2003 at 02:37:15PM -0400
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
On Mon, Jun 09, 2003 at 02:37:15PM -0400, Jeff Garzik wrote:
> On Mon, Jun 09, 2003 at 11:32:47AM -0700, Matthew Dharm wrote:
> > Could you please not kill all these fields? If you want to remove command,
> > go ahead, but leave the others.
>
> What's wrong with the patch?
>
> It's just killing explicit zero-inits...
I've just been bitten on the ass by lack of specific initialization before,
so I'm overly careful.
BTW, is NULL == (void*)0 everywhere? I seem to recall places where it
isn't....
Matt
--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver
I want my GPFs!!!
-- Stef
User Friendly, 11/9/1998
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
next prev parent reply other threads:[~2003-06-09 18:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-09 16:20 [PATCH] kill of ->command Christoph Hellwig
2003-06-09 16:41 ` Patrick Mansfield
2003-06-09 16:51 ` Christoph Hellwig
2003-06-09 18:04 ` Patrick Mansfield
2003-06-09 18:11 ` Christoph Hellwig
2003-06-09 18:15 ` Russell King
2003-06-09 18:19 ` James Bottomley
2003-06-09 18:22 ` Russell King
2003-06-09 18:32 ` Matthew Dharm
2003-06-09 18:34 ` Christoph Hellwig
2003-06-09 18:37 ` Jeff Garzik
2003-06-09 18:45 ` Matthew Dharm [this message]
2003-06-09 19:05 ` Jeff Garzik
2003-06-09 19:19 ` Tony Battersby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030609114515.D5618@one-eyed-alien.net \
--to=mdharm-scsi@one-eyed-alien.net \
--cc=James.Bottomley@steeleye.com \
--cc=hch@lst.de \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox