From: Christoph Hellwig <hch@lst.de>
To: James.Bottomley@steeleye.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] don't dereference sdev->access_count in dpt_i2o
Date: Mon, 9 Jun 2003 17:18:30 +0200 [thread overview]
Message-ID: <20030609151830.GC1325@lst.de> (raw)
This is nothing a LLDD should ever look at and might go away
completly soon. The uses are for a printk and a racy ioctl.
diff -Nru a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
--- a/drivers/scsi/dpt_i2o.c Sun Jun 8 19:06:49 2003
+++ b/drivers/scsi/dpt_i2o.c Sun Jun 8 19:06:49 2003
@@ -1949,25 +1949,5 @@
case I2ORESCANCMD:
adpt_rescan(pHba);
break;
- case DPT_TARGET_BUSY & 0xFFFF:
- case DPT_TARGET_BUSY:
- {
- TARGET_BUSY_T busy;
- struct adpt_device* d;
-
- if (copy_from_user((void*)&busy, (void*)arg, sizeof(TARGET_BUSY_T))) {
- return -EFAULT;
- }
-
- d = adpt_find_device(pHba, busy.channel, busy.id, busy.lun);
- if(d == NULL){
- return -ENODEV;
- }
- busy.isBusy = ((d->pScsi_dev) && (0 != d->pScsi_dev->access_count)) ? 1 : 0;
- if (copy_to_user ((char*)arg, &busy, sizeof(busy))) {
- return -EFAULT;
- }
- break;
- }
default:
return -EINVAL;
@@ -2492,10 +2473,6 @@
printk(KERN_WARNING"%s: Device (%d,%d,%d) offline\n",pHba->name,pDev->scsi_channel,pDev->scsi_id,pDev->scsi_lun);
if (pDev->pScsi_dev) {
pDev->pScsi_dev->online = FALSE;
- if (pDev->pScsi_dev->access_count) {
- // A drive that was mounted is no longer there... bad!
- printk(KERN_WARNING"%s:Mounted drive taken offline\n",pHba->name);
- }
}
}
}
reply other threads:[~2003-06-09 15:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030609151830.GC1325@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox