* [PATCH] don't dereference sdev->access_count in dpt_i2o
@ 2003-06-09 15:18 Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2003-06-09 15:18 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi
This is nothing a LLDD should ever look at and might go away
completly soon. The uses are for a printk and a racy ioctl.
diff -Nru a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
--- a/drivers/scsi/dpt_i2o.c Sun Jun 8 19:06:49 2003
+++ b/drivers/scsi/dpt_i2o.c Sun Jun 8 19:06:49 2003
@@ -1949,25 +1949,5 @@
case I2ORESCANCMD:
adpt_rescan(pHba);
break;
- case DPT_TARGET_BUSY & 0xFFFF:
- case DPT_TARGET_BUSY:
- {
- TARGET_BUSY_T busy;
- struct adpt_device* d;
-
- if (copy_from_user((void*)&busy, (void*)arg, sizeof(TARGET_BUSY_T))) {
- return -EFAULT;
- }
-
- d = adpt_find_device(pHba, busy.channel, busy.id, busy.lun);
- if(d == NULL){
- return -ENODEV;
- }
- busy.isBusy = ((d->pScsi_dev) && (0 != d->pScsi_dev->access_count)) ? 1 : 0;
- if (copy_to_user ((char*)arg, &busy, sizeof(busy))) {
- return -EFAULT;
- }
- break;
- }
default:
return -EINVAL;
@@ -2492,10 +2473,6 @@
printk(KERN_WARNING"%s: Device (%d,%d,%d) offline\n",pHba->name,pDev->scsi_channel,pDev->scsi_id,pDev->scsi_lun);
if (pDev->pScsi_dev) {
pDev->pScsi_dev->online = FALSE;
- if (pDev->pScsi_dev->access_count) {
- // A drive that was mounted is no longer there... bad!
- printk(KERN_WARNING"%s:Mounted drive taken offline\n",pHba->name);
- }
}
}
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-06-09 15:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-06-09 15:18 [PATCH] don't dereference sdev->access_count in dpt_i2o Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox