Re: PATCH: (as33) Remove /proc/scsi directory in scsi_remove_host()

[Mike Anderson <andmike@us.ibm.com>]

Alan,
	This is bug, but I do not think this fix will work for non
	legacy callers. LLDDs that just use scsi_add_host and
	scsi_remove_host would have the remove_proc_entry called
	possibly too early.

	I do not have another fix to offer right now as "present" has race
	issues and just moving it might not be a good idea.

Alan Stern [stern@rowland.harvard.edu] wrote:
> ===== scsi_proc.c 1.11 vs edited =====
> --- 1.11/drivers/scsi/scsi_proc.c	Mon May 26 14:01:11 2003
> +++ edited/drivers/scsi/scsi_proc.c	Wed Jun 11 13:22:43 2003
> @@ -149,8 +149,8 @@
>  
>  	sprintf(name,"%d", shost->host_no);
>  	remove_proc_entry(name, shost->hostt->proc_dir);
> -	if (!shost->hostt->present)
> -		remove_proc_entry(shost->hostt->proc_name, proc_scsi);
> +	remove_proc_entry(shost->hostt->proc_name, proc_scsi);
> +	shost->hostt->proc_dir = NULL;
>  }
>  
>  static void proc_print_scsidevice(struct scsi_device* sdev, char *buffer,
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-andmike
--
Michael Anderson
andmike@us.ibm.com