public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: linux-scsi@vger.kernel.org
Cc: akpm@digeo.com
Subject: [PATCH] remove a bogus check in sym2 driver
Date: Tue, 24 Jun 2003 13:34:22 +1000	[thread overview]
Message-ID: <20030624033422.GB927@krispykreme> (raw)


Hi,

The sym2 driver has a check for a very broken bios where it seems 
devices appear twice. This test is broken on a machine with PCI domains
since busnumber:devfn is not a unique identifier.

When we move to the scsi hotplug interface all this code will go away
but in the short term we need the following fix.

Anton

===== drivers/scsi/sym53c8xx_2/sym_glue.c 1.23 vs edited =====
--- 1.23/drivers/scsi/sym53c8xx_2/sym_glue.c	Tue Jun 10 09:09:11 2003
+++ edited/drivers/scsi/sym53c8xx_2/sym_glue.c	Tue Jun 17 10:37:43 2003
@@ -2752,14 +2757,6 @@
 		}
 		/* This one is guaranteed by AC to do nothing :-) */
 		if (pci_enable_device(pcidev))
-			continue;
-		/* Some HW as the HP LH4 may report twice PCI devices */
-		for (i = 0; i < count ; i++) {
-			if (devtbl[i].s.bus       == PciBusNumber(pcidev) && 
-			    devtbl[i].s.device_fn == PciDeviceFn(pcidev))
-				break;
-		}
-		if (i != count)	/* Ignore this device if we already have it */
 			continue;
 		devp = &devtbl[count];
 		devp->host_id = SYM_SETUP_HOST_ID;

             reply	other threads:[~2003-06-24  3:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-24  3:34 Anton Blanchard [this message]
2003-06-24  8:02 ` [PATCH] remove a bogus check in sym2 driver Alan Cox
2003-06-24  8:17   ` Andrew Morton
2003-06-24 11:22     ` Alan Cox
2003-06-24  8:20   ` Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030624033422.GB927@krispykreme \
    --to=anton@samba.org \
    --cc=akpm@digeo.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox