[PATCH] remove a bogus check in sym2 driver

[PATCH] remove a bogus check in sym2 driver

[Anton Blanchard]

Hi,

The sym2 driver has a check for a very broken bios where it seems 
devices appear twice. This test is broken on a machine with PCI domains
since busnumber:devfn is not a unique identifier.

When we move to the scsi hotplug interface all this code will go away
but in the short term we need the following fix.

Anton

===== drivers/scsi/sym53c8xx_2/sym_glue.c 1.23 vs edited =====
--- 1.23/drivers/scsi/sym53c8xx_2/sym_glue.c	Tue Jun 10 09:09:11 2003
+++ edited/drivers/scsi/sym53c8xx_2/sym_glue.c	Tue Jun 17 10:37:43 2003
@@ -2752,14 +2757,6 @@
 		}
 		/* This one is guaranteed by AC to do nothing :-) */
 		if (pci_enable_device(pcidev))
-			continue;
-		/* Some HW as the HP LH4 may report twice PCI devices */
-		for (i = 0; i < count ; i++) {
-			if (devtbl[i].s.bus       == PciBusNumber(pcidev) && 
-			    devtbl[i].s.device_fn == PciDeviceFn(pcidev))
-				break;
-		}
-		if (i != count)	/* Ignore this device if we already have it */
 			continue;
 		devp = &devtbl[count];
 		devp->host_id = SYM_SETUP_HOST_ID;

Re: [PATCH] remove a bogus check in sym2 driver

[Alan Cox]

On Maw, 2003-06-24 at 04:34, Anton Blanchard wrote:
> Hi,
> 
> The sym2 driver has a check for a very broken bios where it seems 
> devices appear twice. This test is broken on a machine with PCI domains
> since busnumber:devfn is not a unique identifier.
> 
> When we move to the scsi hotplug interface all this code will go away
> but in the short term we need the following fix.

Hardly. When you move to scsi hotplug you'll still have to work around
the boxes where the same device pops up multiple times.

Just check the domain is 0 ?

Re: [PATCH] remove a bogus check in sym2 driver

[Andrew Morton]

Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> > When we move to the scsi hotplug interface all this code will go away
>  > but in the short term we need the following fix.
> 
>  Hardly. When you move to scsi hotplug you'll still have to work around
>  the boxes where the same device pops up multiple times.
> 
>  Just check the domain is 0 ?
> 

Is this a bug in the adapter's BIOS or in the main BIOS?

If the latter then shouldn't this workaround live somewhere other than
$RANDOM_DRIVER?

Re: [PATCH] remove a bogus check in sym2 driver

[Anton Blanchard]

> Hardly. When you move to scsi hotplug you'll still have to work around
> the boxes where the same device pops up multiple times.
> 
> Just check the domain is 0 ?

I would have thought these things would be done at a higher level (eg
the x86 probe code). Whats there to stop this broken bios from showing
network cards up twice?

Anton

Re: [PATCH] remove a bogus check in sym2 driver

[Alan Cox]

On Maw, 2003-06-24 at 09:17, Andrew Morton wrote:
> Is this a bug in the adapter's BIOS or in the main BIOS?
> 
> If the latter then shouldn't this workaround live somewhere other than
> $RANDOM_DRIVER?

Who knows. The NCR/SYM stuff on some mainboards is deeply strange. As to
it being in a random driver - its not, its in the specific afflicted case.

That doesn't mean I disagree about the idea of filtering the problem in
the x86 pci code