From: Adrian Bunk <bunk@fs.tum.de>
To: Gerard Roudier <groudier@free.fr>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: 2.5.73: integer constants in sym53c8xx_2/sym_glue.c too big for int
Date: Tue, 24 Jun 2003 20:07:10 +0200 [thread overview]
Message-ID: <20030624180710.GY3710@fs.tum.de> (raw)
The patch below postfixes a constant in sym53c8xx_2/sym_glue.c with ULL,
on 32 bit archs this constant is too big for an int.
The other problem is the PciDmaMask #if SYM_CONF_DMA_ADDRESSING_MODE == 1:
Are the _ten_ "f"'s intended (making the constant bigger than the size
of an int on 32 bit archs)?
cu
Adrian
--- linux-2.5.73-not-full/drivers/scsi/sym53c8xx_2/sym_glue.c.old 2003-06-24 19:53:04.000000000 +0200
+++ linux-2.5.73-not-full/drivers/scsi/sym53c8xx_2/sym_glue.c 2003-06-24 19:56:01.000000000 +0200
@@ -1863,7 +1863,7 @@
#if SYM_CONF_DMA_ADDRESSING_MODE == 1
#define PciDmaMask 0xffffffffff
#elif SYM_CONF_DMA_ADDRESSING_MODE == 2
-#define PciDmaMask 0xffffffffffffffff
+#define PciDmaMask 0xffffffffffffffffULL
#endif
if (np->features & FE_DAC) {
if (!pci_set_dma_mask(np->s.device, PciDmaMask)) {
reply other threads:[~2003-06-24 18:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030624180710.GY3710@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=groudier@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox