* 2.5.73: integer constants in sym53c8xx_2/sym_glue.c too big for int
@ 2003-06-24 18:07 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2003-06-24 18:07 UTC (permalink / raw)
To: Gerard Roudier; +Cc: linux-scsi, linux-kernel
The patch below postfixes a constant in sym53c8xx_2/sym_glue.c with ULL,
on 32 bit archs this constant is too big for an int.
The other problem is the PciDmaMask #if SYM_CONF_DMA_ADDRESSING_MODE == 1:
Are the _ten_ "f"'s intended (making the constant bigger than the size
of an int on 32 bit archs)?
cu
Adrian
--- linux-2.5.73-not-full/drivers/scsi/sym53c8xx_2/sym_glue.c.old 2003-06-24 19:53:04.000000000 +0200
+++ linux-2.5.73-not-full/drivers/scsi/sym53c8xx_2/sym_glue.c 2003-06-24 19:56:01.000000000 +0200
@@ -1863,7 +1863,7 @@
#if SYM_CONF_DMA_ADDRESSING_MODE == 1
#define PciDmaMask 0xffffffffff
#elif SYM_CONF_DMA_ADDRESSING_MODE == 2
-#define PciDmaMask 0xffffffffffffffff
+#define PciDmaMask 0xffffffffffffffffULL
#endif
if (np->features & FE_DAC) {
if (!pci_set_dma_mask(np->s.device, PciDmaMask)) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-06-24 18:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-06-24 18:07 2.5.73: integer constants in sym53c8xx_2/sym_glue.c too big for int Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox