From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Haverkamp <markh@osdl.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] 2.5.73 add mode sense 10 byte to aacraid driver
Date: Wed, 25 Jun 2003 14:16:09 -0400 [thread overview]
Message-ID: <20030625181609.GA1804@gtf.org> (raw)
In-Reply-To: <1056561660.747.7.camel@markh1.pdx.osdl.net>
On Wed, Jun 25, 2003 at 10:21:00AM -0700, Mark Haverkamp wrote:
> The aacraid driver didn't have a case for the 10 byte mode sense
> command. This was causing the driver to fail. I added a case in
> aac_scsi_cmd for the 10 byte mode sense. I also replaced the aacraid
> definitions for scsi commands with the ones from scsi.h. I have tested
> this on my aacraid hardware here at osdl.
>
> ===== drivers/scsi/aacraid/aachba.c 1.17 vs edited =====
> --- 1.17/drivers/scsi/aacraid/aachba.c Thu Jun 19 17:06:21 2003
> +++ edited/drivers/scsi/aacraid/aachba.c Wed Jun 25 08:24:48 2003
In addition to James's comments...
Please separate the cleanup (private -> scsi.h constants)
from the MODE SENSE 10 stuff, into two separate patches.
That way we can apply the cleanup, while discussioning the other stuff.
Jeff
next prev parent reply other threads:[~2003-06-25 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-25 17:21 [PATCH] 2.5.73 add mode sense 10 byte to aacraid driver Mark Haverkamp
2003-06-25 17:58 ` James Bottomley
2003-06-26 16:13 ` Mark Haverkamp
2003-06-25 18:16 ` Jeff Garzik [this message]
2003-06-25 19:49 ` Mark Haverkamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030625181609.GA1804@gtf.org \
--to=jgarzik@pobox.com \
--cc=James.Bottomley@steeleye.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-scsi@vger.kernel.org \
--cc=markh@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox