Re: use_10_for_ms revisited?

[Matthew Dharm <mdharm-scsi@one-eyed-alien.net>]

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

On Sun, Jun 29, 2003 at 01:58:04PM -0400, Jeff Garzik wrote:
> I grant you that ATAPI is not the whole world, here, but it presents 
> sufficient cases to warrant a common approach.  Both ide-scsi and usb 
> storage (and my ata-scsi driver) have atapi-specific logic in them for 
> 6-to-10 translation.  We can keep adding hueristic upon hueristic to the 
> kernel to handle these things, or we can step back, look at the bigger 
> picture, and take advantage of the commonality found.

Right now, we can handle this case with a slave_configure() function that
sets use_10_for_ms and use_10_for_rw, like usb-storage does now.  The
heuristic code in usb-storage is on the way out, once sr.c is converted (in
progress).

Devices easily identified, heuristics gone, repeated code very minimal (2
lines) -- sounds like a winner to me.  Actually, I have a feeling that any
algorithm to try to determine MMC or not (complete with it's own heuristic
to handle strange devices) will be much longer than those repeated 2 lines.

Matt

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

I don't have a left mouse button.  I only have one mouse and it's on my right.
					-- Customer
User Friendly, 2/13/1999

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]