* PATCH: scsi_debug bug
@ 2003-06-29 19:04 Jeff Garzik
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2003-06-29 19:04 UTC (permalink / raw)
To: linux-scsi
This is for 2.5, but should go back to 2.4 I suppose.
MODE_SENSE_10 alloc_len LSB is in cdb byte 8, not byte 6, AFAIK...
Jeff
===== drivers/scsi/scsi_debug.c 1.39 vs edited =====
--- 1.39/drivers/scsi/scsi_debug.c Mon Jun 2 20:42:21 2003
+++ edited/drivers/scsi/scsi_debug.c Sun Jun 29 15:06:03 2003
@@ -687,7 +687,7 @@
pcontrol = (cmd[2] & 0xc0) >> 6;
pcode = cmd[2] & 0x3f;
msense_6 = (MODE_SENSE == cmd[0]);
- alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[6]);
+ alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[8]);
/* printk(KERN_INFO "msense: dbd=%d pcontrol=%d pcode=%d "
"msense_6=%d alloc_len=%d\n", dbd, pcontrol, pcode, "
"msense_6, alloc_len); */
^ permalink raw reply [flat|nested] 4+ messages in thread
* PATCH: scsi_debug bug
@ 2003-07-06 15:38 Jeff Garzik
2003-07-08 18:00 ` dougg
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2003-07-06 15:38 UTC (permalink / raw)
To: dougg, SCSI Mailing List
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
No response the first time. Resending.
Can someone look at this patch and approve it, please?
It looks like an obvious bug and fix to me: MODE_SENSE_10 allocation
length LSB is in cdb byte 8, not byte 6.
This bug is present in both 2.4 and 2.5.
Jeff
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 560 bytes --]
===== drivers/scsi/scsi_debug.c 1.39 vs edited =====
--- 1.39/drivers/scsi/scsi_debug.c Mon Jun 2 20:42:21 2003
+++ edited/drivers/scsi/scsi_debug.c Sun Jun 29 15:06:03 2003
@@ -687,7 +687,7 @@
pcontrol = (cmd[2] & 0xc0) >> 6;
pcode = cmd[2] & 0x3f;
msense_6 = (MODE_SENSE == cmd[0]);
- alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[6]);
+ alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[8]);
/* printk(KERN_INFO "msense: dbd=%d pcontrol=%d pcode=%d "
"msense_6=%d alloc_len=%d\n", dbd, pcontrol, pcode, "
"msense_6, alloc_len); */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH: scsi_debug bug
2003-07-06 15:38 Jeff Garzik
@ 2003-07-08 18:00 ` dougg
2003-07-08 22:18 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: dougg @ 2003-07-08 18:00 UTC (permalink / raw)
To: Jeff Garzik; +Cc: SCSI Mailing List
Quoting Jeff Garzik <jgarzik@pobox.com>:
> No response the first time. Resending.
>
> Can someone look at this patch and approve it, please?
>
> It looks like an obvious bug and fix to me: MODE_SENSE_10 allocation
> length LSB is in cdb byte 8, not byte 6.
>
> This bug is present in both 2.4 and 2.5.
Jeff,
Guilty as charged.
Sorry for the long delay in responding. Hopefully James
and/or Mike Anderson can put the patch in the bk scsi
repository for the lk 2.5 series.
For the lk 2.4 series, please send a patch to Marcelo
and cc Alan.
Doug Gilbert
-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH: scsi_debug bug
2003-07-08 18:00 ` dougg
@ 2003-07-08 22:18 ` Alan Cox
0 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2003-07-08 22:18 UTC (permalink / raw)
To: dougg; +Cc: Jeff Garzik, SCSI Mailing List
On Maw, 2003-07-08 at 19:00, dougg@torque.net wrote:
> Guilty as charged.
>
> Sorry for the long delay in responding. Hopefully James
> and/or Mike Anderson can put the patch in the bk scsi
> repository for the lk 2.5 series.
>
> For the lk 2.4 series, please send a patch to Marcelo
> and cc Alan.
Already merged
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-07-08 22:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-06-29 19:04 PATCH: scsi_debug bug Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2003-07-06 15:38 Jeff Garzik
2003-07-08 18:00 ` dougg
2003-07-08 22:18 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox