Re: [PATCH] add sysfs attributes to scan and delete scsi_devices

[Patrick Mansfield <patmans@us.ibm.com>]

On Tue, Jul 08, 2003 at 10:13:51PM +0100, Christoph Hellwig wrote:
> On Tue, Jul 08, 2003 at 03:50:15PM -0500, James Bottomley wrote:
> > I'm not convinced we need a bus file for this.  What's the reason we
> > can't have a per host file instead?
> > 
> > I'm thinking of the hotplug case where you know the sysfs path to the
> > card just inserted.  Translating that to a hostid will be rather hard.
> 
> After thinking about this again I tend to agree with you that a per-host
> file sounds like the better idea.

James/Christoph -

There is not much of a difference either way.

Scanning makes more sense as a host attribute (or as a target attribute,
but we don't have a target device today). Deletion of a scsi_device makes
more sense as a /sysfs/bus/scsi (or even scsi_device) attribute that takes
a bus_id. 

But we should be symmetrical for a user space interface. (And it is easier
to catch sscanf errors using spaces as a separator.)

I'll go ahead and redo it as per-host, and move string parsing into
scsi_sysfs.c.

Thanks for the feedback.

-- Patrick Mansfield