Re: [TRIVIAL] [2.5 patch] remove an unused function from NCR53c406a.c

[Adrian Bunk <bunk@fs.tum.de>]

On Tue, Jul 08, 2003 at 11:27:45AM +1000, Rusty Russell wrote:
> In message <1057586204.1812.2.camel@mulgrave> you write:
> > On Mon, 2003-07-07 at 02:46, Rusty Trivial Russell wrote:
> > > From:  Adrian Bunk <bunk@fs.tum.de>
> > > 
> > >   The patch below removes an unused function from 
> > >   drivers/scsi/NCR53c406a.c .
> > >    
> > >   I've tested the compilation with 2.5.72-mm2.
> > 
> > Rusty, I'm not going to remove this immediately.
> > 
> > It's the old polling interface for the chip.  It was unplumbed when the
> > ->command() API was removed, but these chips were strangely connected to
> > soundblaster cards and may need to operate in no-interrupt mode (in
> > which case we'll need to ressurect it).  I'm just waiting to see if
> > anyone complains that their sound card attached CDROM no-longer works.
> 
> Thanks for taking the time to explain, James.  From the other patches
> Adrian sent, I think he was on a warning hunt.

Yup, that's correct.

> I'll turn off re-transmit on this patch, so if it gets applied later
> Adrian will get a closure mail, otherwise I'll dredge it up again late
> in the 2.6-pre stuff.

That's OK for me.

> Thanks!
> Rusty.

Thanks
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed