From: Christoph Hellwig <hch@infradead.org>
To: Anton Blanchard <anton@samba.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: sym2 error handler sleeps with irqs off
Date: Sun, 13 Jul 2003 14:35:33 +0100 [thread overview]
Message-ID: <20030713143533.A24729@infradead.org> (raw)
In-Reply-To: <20030711062045.GA9236@krispykreme>; from anton@samba.org on Fri, Jul 11, 2003 at 04:20:46PM +1000
On Fri, Jul 11, 2003 at 04:20:46PM +1000, Anton Blanchard wrote:
> + local_save_flags(flags);
I don't think you need to save the flags.
> + spin_unlock_irq(cmd->device->host->host_lock);
> down(&ep->sem);
> + local_irq_restore(flags);
> + spin_lock(cmd->device->host->host_lock);
When we drop it we should probably drop it as long as it's safe.
prev parent reply other threads:[~2003-07-13 13:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-11 6:20 sym2 error handler sleeps with irqs off Anton Blanchard
2003-07-13 13:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030713143533.A24729@infradead.org \
--to=hch@infradead.org \
--cc=anton@samba.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox