Re: [PATCH] as i/o hang with aacraid driver 2.6.0-test1

Christoph Hellwig
2003-07-18T20:24:24Z

On Fri, Jul 18, 2003 at 03:21:56PM -0500, James Bottomley wrote:
> +++ edited/drivers/block/ll_rw_blk.c Fri Jul 18 14:54:34 2003
> @@ -1518,6 +1518,7 @@
> * @rq: request to be inserted
> * @at_head: insert request at head or tail of queue
> * @data: private data
> + * @reinsert: true if request it a reinsertion of previously processed one
> *
> * Description:
> * Many block devices need to execute commands asynchronously, so they don't
> @@ -1532,7 +1533,7 @@
> * host that is unable to accept a particular command.
> */
> void blk_insert_request(request_queue_t *q, struct request *rq,
> - int at_head, void *data)
> + int at_head, void *data, int reinsert)

Shouldn't the parameter be after at_head for consistency?