Re: qla1280 compile problems

[Christoph Hellwig <hch@lst.de>]

On Tue, Aug 05, 2003 at 09:17:38AM -0700, James Bottomley wrote:
> On Tue, 2003-08-05 at 05:18, Christoph Hellwig wrote:
> > The qla1280 update still has some issues, mostly because it backs
> > out all the 2.5 changes applied to the driver in the last months,
> > also it doesn't work on ia64 because the IA64 generic build references
> > sn2-specific symbols that don't exist in that build.
> 
> Could you be more explicit on this?  I thought I'd re-added all of the
> backed out patches (although I might have missed some).


These seem to be missing at least

 - remove all #include <linux/blk.h>'s (Adrian Bunk)
 - give ->proc_info a struct Scsi_Host * paramter (me)
 - move all host templates into .c files (me)
 - Spellig fixes for consistent, dependent and persistent
 - Spellig fixes
 - [patch, 2.5] scsi_qla1280.c free on error path
 

> For what it's worth, this compiled for me without warnings on parisc64
> (although I haven't got around to actually testing it).

strange, I can's see how it could compile at least with the superflous
initializer for sht.command.