From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] oops in sd_shutdown Date: Tue, 12 Aug 2003 07:53:53 +0100 Sender: linux-kernel-owner@vger.kernel.org Message-ID: <20030812075353.A18547@infradead.org> References: <20030812002844.B1353@pclin040.win.tue.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20030812002844.B1353@pclin040.win.tue.nl>; from aebr@win.tue.nl on Tue, Aug 12, 2003 at 12:28:44AM +0200 To: Andries Brouwer Cc: linux-scsi@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Tue, Aug 12, 2003 at 12:28:44AM +0200, Andries Brouwer wrote: > I see an Oops in the SCSI code, caused by the fact that sdkp is NULL > in sd_shutdown. "How can that be?", you will ask - dev->driver_data was set > in sd_probe. But in my case sd_probe never finished. An insmod usb-storage > hangs forever, or at least for more than six hours, giving ample opportunity > to observe this race between sd_probe and sd_shutdown. > (Of course sd_probe hangs in sd_revalidate disk.) Well, this same problem could show upb in any other driver. Could you instead send a patch to Pat that the driver model never calls the shutdown method for a driver that hasn't finished ->probe?