From: Anton Blanchard <anton@samba.org>
To: Matthew Wilcox <willy@debian.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Convert sym2 to be hotplug-capable
Date: Wed, 13 Aug 2003 09:41:33 +1000 [thread overview]
Message-ID: <20030812234133.GA30156@krispykreme> (raw)
In-Reply-To: <20030716210059.GR23808@parcelfarce.linux.theplanet.co.uk>
Hi,
> This patch is on top of the patch I posted yesterday. It..
> - Stops using Scsi_Cmnd etc typedefs
> - Removes the unused Scsi_Host_Template argument from sym53c8xx_pci_init
> - Converts sym53c8xx_2 to be a hotplug-capable driver
One problem we found when we hit a bad adapter, we need to use scsi_host_put.
James, what are the chances of getting Willy's sym2 fixes in? Its much
more predictable than the current probe order.
Anton
--- gr13_work_miltonm_l4/drivers/scsi/sym53c8xx_2/sym_glue.c~ 2003-08-12 18:33:03.000000000 -0500
+++ gr13_work_miltonm_l4/drivers/scsi/sym53c8xx_2/sym_glue.c 2003-08-12 18:33:45.000000000 -0500
@@ -2030,7 +2030,7 @@
printf_info("%s: giving up ...\n", sym_name(np));
if (np)
sym_free_resources(np);
- scsi_unregister(instance);
+ scsi_host_put(instance);
return -1;
}
next prev parent reply other threads:[~2003-08-12 23:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-16 21:00 [PATCH] Convert sym2 to be hotplug-capable Matthew Wilcox
2003-07-19 18:28 ` Anton Blanchard
2003-07-20 21:55 ` Matthew Wilcox
2003-08-12 23:41 ` Anton Blanchard [this message]
2003-08-13 5:13 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030812234133.GA30156@krispykreme \
--to=anton@samba.org \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox