From: Christoph Hellwig <hch@infradead.org>
To: Jamie Lenehan <lenehan@twibble.org>
Cc: linux-scsi@vger.kernel.org, dc395x@twibble.org
Subject: Re: [PATCH] dc395x [1/6] - make functions static
Date: Tue, 26 Aug 2003 17:54:02 +0100 [thread overview]
Message-ID: <20030826175401.A29464@infradead.org> (raw)
In-Reply-To: <20030826112235.GA8609@twibble.org>; from lenehan@twibble.org on Tue, Aug 26, 2003 at 09:22:35PM +1000
On Tue, Aug 26, 2003 at 09:22:35PM +1000, Jamie Lenehan wrote:
> On Thu, Aug 21, 2003 at 11:46:32AM +0100, Christoph Hellwig wrote:
> [...]
> > the static belongs on the same line as the prototype.
>
> Well... I disagree and there's no mention of it in CodingStyle...
Well, that's how the Linux core code is written and how the examples
in Documentation/CodingStyle is written. I'll ping Linus about
explicitly mentioning it when he returns.
> but
> having said I don't actually care that much! I'll note it down in my
> list to things to change. (I'd rather do it all at once if I'm going
> to do it then one bit at a time and having a mix of styles.)
Thanks.
next prev parent reply other threads:[~2003-08-26 16:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-21 10:13 [PATCH] dc395x [0/6] - description Jamie Lenehan
2003-08-21 10:14 ` [PATCH] dc395x [1/6] - make functions static Jamie Lenehan
2003-08-21 10:15 ` [PATCH] dc395x [2/6] - cleanup devices Jamie Lenehan
2003-08-21 10:16 ` [PATCH] dc395x [3/6] - cleanup adapter init Jamie Lenehan
2003-08-21 10:16 ` [PATCH] dc395x [4/6] - cleanup adapter uninit Jamie Lenehan
2003-08-21 10:17 ` [PATCH] dc395x [5/6] - check for device Jamie Lenehan
2003-08-21 10:17 ` [PATCH] dc395x [6/6] - use pci resource len Jamie Lenehan
2003-08-21 10:46 ` [PATCH] dc395x [1/6] - make functions static Christoph Hellwig
2003-08-26 11:22 ` Jamie Lenehan
2003-08-26 16:54 ` Christoph Hellwig [this message]
2003-08-21 11:02 ` [Dc395x] [PATCH] dc395x [0/6] - description Ali Akcaagac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030826175401.A29464@infradead.org \
--to=hch@infradead.org \
--cc=dc395x@twibble.org \
--cc=lenehan@twibble.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox