From: Andrew Morton <akpm@osdl.org>
To: linux-scsi@vger.kernel.org
Subject: Re: OOps in 2.6.0-test4-mm3-1
Date: Sat, 30 Aug 2003 10:00:31 -0700 [thread overview]
Message-ID: <20030830100031.26dfca8e.akpm@osdl.org> (raw)
In-Reply-To: <20030829200926.3e2b7eb6.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
>
> diff -puN drivers/scsi/hosts.c~scsi_unregister-oops-fix drivers/scsi/hosts.c
> --- 25/drivers/scsi/hosts.c~scsi_unregister-oops-fix 2003-08-29 20:02:53.000000000 -0700
> +++ 25-akpm/drivers/scsi/hosts.c 2003-08-29 20:02:53.000000000 -0700
> @@ -297,8 +297,12 @@ struct Scsi_Host *scsi_register(struct s
> dump_stack();
> }
>
> - if (shost)
> + if (shost) {
> list_add_tail(&shost->sht_legacy_list, &sht->legacy_hosts);
> + } else {
> + /* Do this to keep scsi_unregister() happy */
> + INIT_LIST_HEAD(&shost->sht_legacy_list);
> + }
> return shost;
> }
Manfred points out that this one is crap. The scsi_host_dev_release()
patch is sufficient.
But I did get an oops in a separate place with just that patch (doing
modprobe aha1542 with no hardware) butthat seems to have gone away now.
Sigh.
next prev parent reply other threads:[~2003-08-30 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030828235649.61074690.akpm@osdl.org>
[not found] ` <20030830014309.GA898@matchmail.com>
2003-08-30 3:09 ` OOps in 2.6.0-test4-mm3-1 Andrew Morton
2003-08-30 17:00 ` Andrew Morton [this message]
2003-08-30 23:20 ` Mike Fedyk
2003-08-30 23:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030830100031.26dfca8e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox