* [TRIVIAL] [2.5 patch] remove an unused function from wd7000.c
@ 2003-09-04 3:12 Rusty Trivial Russell
2003-09-04 7:27 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Rusty Trivial Russell @ 2003-09-04 3:12 UTC (permalink / raw)
To: John Boyd, Miroslav Zagorac, linux-scsi, axboe
From: Adrian Bunk <bunk@fs.tum.de>
The patch below removes an unused function from drivers/scsi/wd7000.c .
I've tested the compilation with 2.5.72-mm2.
cu
Adrian
--- trivial-2.6.0-test4-bk5/drivers/scsi/wd7000.c.orig 2003-09-04 13:01:35.000000000 +1000
+++ trivial-2.6.0-test4-bk5/drivers/scsi/wd7000.c 2003-09-04 13:01:35.000000000 +1000
@@ -1605,22 +1605,6 @@
}
/*
- * I have absolutely NO idea how to do an abort with the WD7000...
- */
-static int wd7000_abort(Scsi_Cmnd * SCpnt)
-{
- Adapter *host = (Adapter *) SCpnt->device->host->hostdata;
-
- if (inb(host->iobase + ASC_STAT) & INT_IM) {
- printk("wd7000_abort: lost interrupt\n");
- wd7000_intr_handle(host->irq, NULL, NULL);
- return FAILED;
- }
- return FAILED;
-}
-
-
-/*
* I also have no idea how to do a reset...
*/
--
What is this? http://www.kernel.org/pub/linux/kernel/people/rusty/trivial/
Don't blame me: the Monkey is driving
File: Adrian Bunk <bunk@fs.tum.de>: [2.5 patch] remove an unused function from wd7000.c
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [TRIVIAL] [2.5 patch] remove an unused function from wd7000.c
2003-09-04 3:12 [TRIVIAL] [2.5 patch] remove an unused function from wd7000.c Rusty Trivial Russell
@ 2003-09-04 7:27 ` Christoph Hellwig
2003-09-04 10:09 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2003-09-04 7:27 UTC (permalink / raw)
To: Rusty Trivial Russell; +Cc: John Boyd, Miroslav Zagorac, linux-scsi, axboe
On Thu, Sep 04, 2003 at 01:12:12PM +1000, Rusty Trivial Russell wrote:
> From: Adrian Bunk <bunk@fs.tum.de>
>
> The patch below removes an unused function from drivers/scsi/wd7000.c .
>
> I've tested the compilation with 2.5.72-mm2.
Alan said he wanted to keep this for some reason. Maybe #if 0 it out?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [TRIVIAL] [2.5 patch] remove an unused function from wd7000.c
2003-09-04 7:27 ` Christoph Hellwig
@ 2003-09-04 10:09 ` Alan Cox
2003-09-06 6:51 ` Miroslav Zagorac
0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2003-09-04 10:09 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Rusty Trivial Russell, John Boyd, Miroslav Zagorac, linux-scsi,
axboe
On Iau, 2003-09-04 at 08:27, Christoph Hellwig wrote:
> > The patch below removes an unused function from drivers/scsi/wd7000.c .
> >
> > I've tested the compilation with 2.5.72-mm2.
>
> Alan said he wanted to keep this for some reason. Maybe #if 0 it out?
Because it needs converting to an eh_abort handler otherwise the card
will hang if you try and do anything much useful with it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [TRIVIAL] [2.5 patch] remove an unused function from wd7000.c
2003-09-04 10:09 ` Alan Cox
@ 2003-09-06 6:51 ` Miroslav Zagorac
0 siblings, 0 replies; 4+ messages in thread
From: Miroslav Zagorac @ 2003-09-06 6:51 UTC (permalink / raw)
To: Alan Cox
Cc: Christoph Hellwig, Rusty Trivial Russell, John Boyd,
Miroslav Zagorac, linux-scsi, axboe
> On Iau, 2003-09-04 at 08:27, Christoph Hellwig wrote:
> > > The patch below removes an unused function from drivers/scsi/wd7000.c .
> > >
> > > I've tested the compilation with 2.5.72-mm2.
> >
> > Alan said he wanted to keep this for some reason. Maybe #if 0 it out?
>
> Because it needs converting to an eh_abort handler otherwise the card
> will hang if you try and do anything much useful with it.
>
Hello. I will make some effort to convert function to eh_abort handler,
very soon. I'm sorry for late answer and bad english.
--
Zaga
Honi soit qui mal y pense.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-09-06 6:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-04 3:12 [TRIVIAL] [2.5 patch] remove an unused function from wd7000.c Rusty Trivial Russell
2003-09-04 7:27 ` Christoph Hellwig
2003-09-04 10:09 ` Alan Cox
2003-09-06 6:51 ` Miroslav Zagorac
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox