From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH] kill use_blk_tcq template flag
Date: Sat, 20 Sep 2003 10:34:59 +0200 [thread overview]
Message-ID: <20030920083459.GD20301@lst.de> (raw)
The flag isn't checked ever as drivers using the block layer tcq
code do so by themselves, without any interaction to the scsi midlayer.
diff -Nru a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
--- a/drivers/scsi/53c700.c Sat Sep 20 09:35:53 2003
+++ b/drivers/scsi/53c700.c Sat Sep 20 09:35:53 2003
@@ -281,7 +281,6 @@
tpnt->use_clustering = DISABLE_CLUSTERING;
tpnt->slave_configure = NCR_700_slave_configure;
tpnt->slave_destroy = NCR_700_slave_destroy;
- tpnt->use_blk_tcq = 1;
if(tpnt->name == NULL)
tpnt->name = "53c700";
diff -Nru a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
--- a/drivers/scsi/hosts.c Sat Sep 20 09:35:53 2003
+++ b/drivers/scsi/hosts.c Sat Sep 20 09:35:53 2003
@@ -236,7 +236,6 @@
shost->cmd_per_lun = sht->cmd_per_lun;
shost->unchecked_isa_dma = sht->unchecked_isa_dma;
shost->use_clustering = sht->use_clustering;
- shost->use_blk_tcq = sht->use_blk_tcq;
if (sht->max_host_blocked)
shost->max_host_blocked = sht->max_host_blocked;
diff -Nru a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
--- a/include/scsi/scsi_host.h Sat Sep 20 09:35:53 2003
+++ b/include/scsi/scsi_host.h Sat Sep 20 09:35:53 2003
@@ -312,12 +312,6 @@
*/
unsigned emulated:1;
- /*
- * True if the driver wishes to use the generic block layer
- * tag queueing functions
- */
- unsigned use_blk_tcq:1;
-
/*
* Countdown for host blocking with no commands outstanding
*/
reply other threads:[~2003-09-20 8:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030920083459.GD20301@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox