From: Andries Brouwer <aebr@win.tue.nl>
To: Christoph Hellwig <hch@lst.de>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] move some constants around
Date: Sat, 20 Sep 2003 18:50:37 +0200 [thread overview]
Message-ID: <20030920185037.A3530@pclin040.win.tue.nl> (raw)
In-Reply-To: <20030920133335.GA23251@lst.de>; from hch@lst.de on Sat, Sep 20, 2003 at 03:33:35PM +0200
On Sat, Sep 20, 2003 at 03:33:35PM +0200, Christoph Hellwig wrote:
> We should try to keep all constants in include/scsi/scsi.h instead
> of drivers/scsi/scsi.h. Also tidy up include/scsi/scsi.h a bit.
The original design purpose of include/scsi/scsi.h versus
drivers/scsi/scsi.h was to have constants that are meaningful
in user space (such as constants defined in the SCSI standard)
in <scsi/scsi.h>, while kernel-internal stuff lived in
drivers/scsi/scsi.h.
Thus, I do not see this move as an improvement.
Andries
> /*
> * This header file contains public constants and structures used by
> * the scsi code for linux.
> */
next prev parent reply other threads:[~2003-09-20 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-20 13:33 [PATCH] move some constants around Christoph Hellwig
2003-09-20 16:50 ` Andries Brouwer [this message]
2003-09-20 18:11 ` Christoph Hellwig
2003-09-20 18:34 ` Andries Brouwer
2003-09-20 19:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030920185037.A3530@pclin040.win.tue.nl \
--to=aebr@win.tue.nl \
--cc=James.Bottomley@SteelEye.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox