From: 'Christoph Hellwig' <hch@infradead.org>
To: "Sachin Mhatre (smhatre)" <smhatre@cisco.com>
Cc: 'Jeff Garzik' <jgarzik@pobox.com>, linux-scsi@vger.kernel.org
Subject: Re: [iscsi 2/2] iscsi-probe.c
Date: Wed, 24 Sep 2003 14:48:17 +0100 [thread overview]
Message-ID: <20030924144817.A16189@infradead.org> (raw)
In-Reply-To: <016901c382a1$aadc5da0$8f074d0a@apac.cisco.com>; from smhatre@cisco.com on Wed, Sep 24, 2003 at 07:12:12PM +0530
On Wed, Sep 24, 2003 at 07:12:12PM +0530, Sachin Mhatre (smhatre) wrote:
> Hi,
> The linux-iscsi source code submitted for review is for
> inclusion into the 2.4 linux kernel tree. You can get this source code
> from the linux-iscsi sourceforge branch with the tag
> "linux-iscsi-3-5-branch". Just for convenience here is the cvs command
> for anonymous checkout of this code:-
> cvs -d:pserver:anonymous@cvs.sourceforge.net:/cvsroot/linux-iscsi co -r
> linux-iscsi-3-5-branch linux-iscsi .
>
> We have tested this code on the Redhat Linux 9.0 platform, kernel
> version 2.4.22.
>
> Please let your valuable feedback pour in.
It looks like all comments I posted on linux-scsi apply to the
inux-iscsi-3-5-branch version of iscsi-probe.c, too. So please
stop messing randomly with the namespace and opening files from
kernelspace, respect Documentation/CodingStyle (avoid typedefs,
linebreaks after 80 chars, etc..) and try to use kernel functionality
where available.
Note that I can't help you with redhat inclusion, but for mainline
inclusion we'd like to see a 2.6 version before a 2.4 one. So my
advice would be to concentrate on 2.6 first, the scsi layer is much
nicer anyway there. If that's done backport it to 2.4 which might
require a few bad workarounds and/or small changes to the scsi core.
next prev parent reply other threads:[~2003-09-24 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-23 15:23 [iscsi 2/2] iscsi-probe.c Jeff Garzik
2003-09-23 15:53 ` Christoph Hellwig
2003-09-24 3:43 ` Lincoln Dale
2003-09-24 12:37 ` Christoph Hellwig
2003-09-24 13:42 ` Sachin Mhatre (smhatre)
2003-09-24 13:48 ` 'Christoph Hellwig' [this message]
2003-09-24 14:14 ` Jeff Garzik
2003-09-24 16:20 ` Sachin Mhatre (smhatre)
2003-09-24 16:27 ` Jeff Garzik
2003-09-24 16:40 ` 'Christoph Hellwig'
2003-09-24 17:11 ` Patrick Mansfield
2003-09-24 17:30 ` 'Christoph Hellwig'
2003-09-24 18:26 ` Scott M. Ferris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030924144817.A16189@infradead.org \
--to=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=smhatre@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox