From: 'Christoph Hellwig' <hch@infradead.org>
To: "Sachin Mhatre (smhatre)" <smhatre@cisco.com>
Cc: 'Jeff Garzik' <jgarzik@pobox.com>, linux-scsi@vger.kernel.org
Subject: Re: [iscsi 2/2] iscsi-probe.c
Date: Wed, 24 Sep 2003 17:40:46 +0100 [thread overview]
Message-ID: <20030924174046.A20362@infradead.org> (raw)
In-Reply-To: <018b01c382b7$b7f81220$8f074d0a@apac.cisco.com>; from smhatre@cisco.com on Wed, Sep 24, 2003 at 09:50:02PM +0530
On Wed, Sep 24, 2003 at 09:50:02PM +0530, Sachin Mhatre (smhatre) wrote:
> indent -kr -i8 -ts8 -sob -l80 -ss -bs -psl <filename>.c
> However, this does not handle the log messages in double quotes. We will
> manually take care of such messages.
Please do.
> 2. The opening of files from kernel space is important for the iscsi
> probing mechanism.
It's not. Opening files from kernelspaced is utter crap. Creating
directories and special files from kernelspace is even worse.
> We read/write into the "/proc/scsi/scsi" file for
> configuration/deconfiguration of iSCSI devices.
I see. And that's exactly wrong. Take a look at the usb-storage or sbp2
drivers on how to handle it.
next prev parent reply other threads:[~2003-09-24 16:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-23 15:23 [iscsi 2/2] iscsi-probe.c Jeff Garzik
2003-09-23 15:53 ` Christoph Hellwig
2003-09-24 3:43 ` Lincoln Dale
2003-09-24 12:37 ` Christoph Hellwig
2003-09-24 13:42 ` Sachin Mhatre (smhatre)
2003-09-24 13:48 ` 'Christoph Hellwig'
2003-09-24 14:14 ` Jeff Garzik
2003-09-24 16:20 ` Sachin Mhatre (smhatre)
2003-09-24 16:27 ` Jeff Garzik
2003-09-24 16:40 ` 'Christoph Hellwig' [this message]
2003-09-24 17:11 ` Patrick Mansfield
2003-09-24 17:30 ` 'Christoph Hellwig'
2003-09-24 18:26 ` Scott M. Ferris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030924174046.A20362@infradead.org \
--to=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=smhatre@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox