From: 'Christoph Hellwig' <hch@infradead.org>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: "Sachin Mhatre (smhatre)" <smhatre@cisco.com>,
'Jeff Garzik' <jgarzik@pobox.com>,
linux-scsi@vger.kernel.org
Subject: Re: [iscsi 2/2] iscsi-probe.c
Date: Wed, 24 Sep 2003 18:30:42 +0100 [thread overview]
Message-ID: <20030924183042.A21296@infradead.org> (raw)
In-Reply-To: <20030924101152.A17901@beaverton.ibm.com>; from patmans@us.ibm.com on Wed, Sep 24, 2003 at 10:11:52AM -0700
On Wed, Sep 24, 2003 at 10:11:52AM -0700, Patrick Mansfield wrote:
> > I see. And that's exactly wrong. Take a look at the usb-storage or sbp2
> > drivers on how to handle it.
>
> They could use scsi_scan_host_selected(host, chan, target, SCAN_WILD_CARD,
> 0) or a scan target function, though their current lun scanning looks odd.
Well, if you want to keep their current code. I'm pretty sure they're
much better served with scsi_add_device.
> What was wrong with exporting scsi_scan_host_selected?
There's nothing inherently wrong except that aacraid who wanted it
shouldn't have used it in the first place. And I'm sure that's true
for iscsi, too.
> We don't have a scsi_remove_target().
Indeed. But that nothing that couldn't be easily fixed if we really
wanted it.
next prev parent reply other threads:[~2003-09-24 17:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-23 15:23 [iscsi 2/2] iscsi-probe.c Jeff Garzik
2003-09-23 15:53 ` Christoph Hellwig
2003-09-24 3:43 ` Lincoln Dale
2003-09-24 12:37 ` Christoph Hellwig
2003-09-24 13:42 ` Sachin Mhatre (smhatre)
2003-09-24 13:48 ` 'Christoph Hellwig'
2003-09-24 14:14 ` Jeff Garzik
2003-09-24 16:20 ` Sachin Mhatre (smhatre)
2003-09-24 16:27 ` Jeff Garzik
2003-09-24 16:40 ` 'Christoph Hellwig'
2003-09-24 17:11 ` Patrick Mansfield
2003-09-24 17:30 ` 'Christoph Hellwig' [this message]
2003-09-24 18:26 ` Scott M. Ferris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030924183042.A21296@infradead.org \
--to=hch@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patmans@us.ibm.com \
--cc=smhatre@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox