Re: 1st REVIEW : UNH iSCSI for 2.6-test5

[Christoph Hellwig <hch@infradead.org>]

More comments:

 - unh_iscsi/security should really go away.  We have a nice crypto API
   in 2.6 and late 2.4, but authentification really shouldn't be done
   in kernelspace anyway.
 - kill iscsi_device.c.  A scsi LLDD has no business messing with device
   nodes..
 - you're comment style is strange.  In kernel code we tend to use

/*
 * Foo, blah
 * baz..
 */

not

/*

*/

but that's just a minor nitpick.

Having the module description over the copyright boilerplate also is
very strange.

 - your split into common/ and initiator/ is strange.  You can build
   multiple modules in one directory and that would cleanup your
   includes mess nicely
 - having a single host for all of iscsi looks strange.  Why do you
   do that?
 - the #ifdef K26 is totally unreadble.  Especially when it's around
   code that works for both 2.4 and 2.6..
 - kill my_kmallocd / my_free
 - you seems to not handle lots of error returns, e.g. from down_interruptible
   or kernel_thread
 - the UNH_LOCK/UNH_UNLOCK obsfucation hinders reading
 - kill ISCSI_INITIATOR, there's no need for this #define - just initialize
   the host template directly