From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@debian.org>
Cc: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] more ncr updates
Date: Fri, 26 Sep 2003 17:46:47 +0200 [thread overview]
Message-ID: <20030926154647.GA24222@lst.de> (raw)
In-Reply-To: <20030926154433.GN24824@parcelfarce.linux.theplanet.co.uk>
On Fri, Sep 26, 2003 at 04:44:33PM +0100, Matthew Wilcox wrote:
> > - if ((driver_setup.led_pin ||
> > - (nvram && nvram->type == SCSI_NCR_SYMBIOS_NVRAM)) &&
> > - !(np->features & FE_LEDC) && !(np->sv_gpcntl & 0x01))
> > + if (driver_setup.led_pin)
> > np->features |= FE_LED0;
> >
> > /*
>
> Are you sure this is right? I have:
>
> if ((driver_setup.led_pin) &&
> !(np->features & FE_LEDC) && !(np->sv_gpcntl & 0x01))
> np->features |= FE_LED0;
Yes, you're right.
prev parent reply other threads:[~2003-09-26 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-26 15:17 [PATCH] more ncr updates Christoph Hellwig
2003-09-26 15:44 ` Matthew Wilcox
2003-09-26 15:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030926154647.GA24222@lst.de \
--to=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox