From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@debian.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
Ryan Bradetich <rbradetich@uswest.net>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
PARISC list <parisc-linux@lists.parisc-linux.org>
Subject: Re: zalon/ncr53c720 crashes K460 (parisc port) on bootup.
Date: Sat, 27 Sep 2003 19:43:19 +0100 [thread overview]
Message-ID: <20030927194319.A30759@infradead.org> (raw)
In-Reply-To: <20030927183756.GT24824@parcelfarce.linux.theplanet.co.uk>; from willy@debian.org on Sat, Sep 27, 2003 at 07:37:56PM +0100
On Sat, Sep 27, 2003 at 07:37:56PM +0100, Matthew Wilcox wrote:
> - struct host_data *host_data = (struct host_data *)host->hostdata;
> + struct host_data *host_data;
> #ifdef DEBUG_NCR53C8XX
> printk("ncr53c8xx: release\n");
> #endif
> - if (host_data->ncb)
> + if (!host)
> + return 1;
> + host_data = (struct host_data *)host->hostdata;
> + if (host_data && host_data->ncb)
> ncr_detach(host_data->ncb);
> return 1;
> }
>
> and it does fix the problem. Maybe it's too much checking, but I'm not
> interested in tracking down bugs like this again ;-)
Or better just stop calling ncr53c8xx_release if ncr_attach failed..
next prev parent reply other threads:[~2003-09-27 18:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-27 3:43 zalon/ncr53c720 crashes K460 (parisc port) on bootup Ryan Bradetich
2003-09-27 7:48 ` [parisc-linux] " Matthew Wilcox
2003-09-27 13:45 ` James Bottomley
2003-09-27 15:45 ` James Bottomley
2003-09-27 17:23 ` Matthew Wilcox
2003-09-27 18:37 ` Matthew Wilcox
2003-09-27 18:43 ` Christoph Hellwig [this message]
2003-09-27 18:58 ` James Bottomley
2003-09-27 20:06 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030927194319.A30759@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@steeleye.com \
--cc=linux-scsi@vger.kernel.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=rbradetich@uswest.net \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox