From: Mike Anderson <andmike@us.ibm.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] BusLogic: add error handling, fix queuecommand, docs.
Date: Wed, 1 Oct 2003 14:48:18 -0700 [thread overview]
Message-ID: <20031001214818.GB1045@beaverton.ibm.com> (raw)
In-Reply-To: <20031001122316.6f33af9b.rddunlap@osdl.org>
Randy.Dunlap [rddunlap@osdl.org] wrote:
> +/* Error Handling (EH) support */
> +
> +static int BusLogic_abort(Scsi_Cmnd *SCpnt)
> +{
> + return FAILED;
> +}
> +
> +static int BusLogic_bus_reset(Scsi_Cmnd *SCpnt)
> +{
> + return FAILED;
> +}
> +
> +static int BusLogic_device_reset(Scsi_Cmnd *SCpnt)
> +{
> + return FAILED;
> +}
> +
If the functions are just going to return FAILED you may want to
consider leaving them out. Having these functions return fail will cause
the output to be noisy. Either with this noisy output or not the
recovery will end up at BusLogic_host_reset.
-andmike
--
Michael Anderson
andmike@us.ibm.com
next prev parent reply other threads:[~2003-10-01 21:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-01 19:23 [PATCH] BusLogic: add error handling, fix queuecommand, docs Randy.Dunlap
2003-10-01 21:48 ` Mike Anderson [this message]
2003-10-01 21:43 ` Randy.Dunlap
2003-10-02 0:37 ` Randy.Dunlap
2003-10-02 6:00 ` Mike Anderson
2003-10-02 20:34 ` Doug Ledford
2003-10-02 20:48 ` Randy.Dunlap
2003-10-02 21:04 ` Doug Ledford
2003-10-02 20:59 ` Randy.Dunlap
2003-10-02 20:58 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031001214818.GB1045@beaverton.ibm.com \
--to=andmike@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox