From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 3/3] 2.6.0 aacraid driver update Date: Mon, 6 Oct 2003 22:59:36 +0100 Sender: linux-scsi-owner@vger.kernel.org Message-ID: <20031006215936.GF24824@parcelfarce.linux.theplanet.co.uk> References: <1065475285.17021.79.camel@markh1.pdx.osdl.net> <3F81E34A.1040201@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:29850 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S261746AbTJFV7h (ORCPT ); Mon, 6 Oct 2003 17:59:37 -0400 Content-Disposition: inline In-Reply-To: <3F81E34A.1040201@pobox.com> List-Id: linux-scsi@vger.kernel.org To: Jeff Garzik Cc: Mark Haverkamp , linux-scsi , linux-kernel@vger.kernel.org On Mon, Oct 06, 2003 at 05:48:58PM -0400, Jeff Garzik wrote: > >+ /* > >+ * Yield the processor in case we are slow > >+ */ > >+ set_current_state(TASK_UNINTERRUPTIBLE); > >+ schedule_timeout(1); > > hmmm... why not simply call yield() here instead? I think yield() is > closer to the intent you wish to achieve... Gods, no. I believe it is always a bug for drivers to call yield() in 2.6. What is probably meant here is cond_resched(). I'd support deleting the EXPORT_SYMBOL(yield) line and fixing the breakage afterwards as it causes lots of very subtle breakage ("Under certain circumstances, Linux just stops doing anything for 5 seconds"). -- "It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk