linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Mark aha152x as ISA and !64BIT driver
@ 2003-10-07 17:33 Andi Kleen
  2003-10-07 18:26 ` [PATCH] Mark aha152x as ISA and !64BIT driver II Andi Kleen
  0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2003-10-07 17:33 UTC (permalink / raw)
  To: linux-scsi


aha152x seems to be not 64bit safe and spews out warnings on x86-64. 
As I think it's a ISA only driver anyways I just marked it as
ISA only and !64BIT for Alpha's sake.

diff -u linux-2.5-cleanup/drivers/scsi/Kconfig-o linux-2.5-cleanup/drivers/scsi/Kconfig
--- linux-2.5-cleanup/drivers/scsi/Kconfig-o	2003-10-02 18:12:08.000000000 +0200
+++ linux-2.5-cleanup/drivers/scsi/Kconfig	2003-12-02 16:56:28.620210248 +0100
@@ -253,7 +253,7 @@
 
 config SCSI_AHA152X
 	tristate "Adaptec AHA152X/2825 support"
-	depends on ISA && SCSI
+	depends on ISA && SCSI && ISA && !64BIT
 	---help---
 	  This is a driver for the AHA-1510, AHA-1520, AHA-1522, and AHA-2825
 	  SCSI host adapters. It also works for the AVA-1505, but the IRQ etc.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Mark aha152x as ISA and !64BIT driver II
  2003-10-07 17:33 [PATCH] Mark aha152x as ISA and !64BIT driver Andi Kleen
@ 2003-10-07 18:26 ` Andi Kleen
  0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2003-10-07 18:26 UTC (permalink / raw)
  To: Andi Kleen; +Cc: linux-scsi

On Tue, Oct 07, 2003 at 07:33:23PM +0200, Andi Kleen wrote:
> 
> aha152x seems to be not 64bit safe and spews out warnings on x86-64. 
> As I think it's a ISA only driver anyways I just marked it as
> ISA only and !64BIT for Alpha's sake.


Matthew Wilcox pointed out that it was already marked ISA only.
I actually ment to change another driver, but looking at the source of one
it seems to be 64bit unclean too.

As there are 64bit architectures that have ISA slots (like old Alphas)
I think this patch is still appropiate.

-Andi
 
diff -u linux-2.5-cleanup/drivers/scsi/Kconfig-o linux-2.5-cleanup/drivers/scsi/Kconfig
--- linux-2.5-cleanup/drivers/scsi/Kconfig-o	2003-10-02 18:12:08.000000000 +0200
+++ linux-2.5-cleanup/drivers/scsi/Kconfig	2003-12-02 16:56:28.620210248 +0100
@@ -253,7 +253,7 @@
 
 config SCSI_AHA152X
 	tristate "Adaptec AHA152X/2825 support"
-	depends on ISA && SCSI
+	depends on ISA && SCSI && !64BIT
 	---help---
 	  This is a driver for the AHA-1510, AHA-1520, AHA-1522, and AHA-2825
 	  SCSI host adapters. It also works for the AVA-1505, but the IRQ etc.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-10-07 18:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-10-07 17:33 [PATCH] Mark aha152x as ISA and !64BIT driver Andi Kleen
2003-10-07 18:26 ` [PATCH] Mark aha152x as ISA and !64BIT driver II Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).