Re: [PATCH] megaraid 2.00.09

[Christoph Hellwig <hch@infradead.org>]

- * Copyright © 2002  LSI Logic Corporation.
+ * Copyright © 2002  LSI Logic Corporation.

Strange encoding?

@@ -358,6 +368,21 @@
 		adapter = (adapter_t *)host->hostdata;
 		memset(adapter, 0, sizeof(adapter_t));
 
+		/*
+		 * Allocate a pci device structure for allocations done
+		 * internally - all of which would be in memory <4GB
+		 */
+		adapter->ipdev = kmalloc(sizeof(struct pci_dev), GFP_KERNEL);
+
+		if( adapter->ipdev == NULL ) goto fail_attach;

	This is wrong.  We have the consistent_dma_mask for this.

+
+		got_ipdev_f = 1;

this got_foo / did_foo stuff is crap - use proper gotos for unwinding,

+
+		adapter->host_lock = &adapter->lock;
+
 		scsi_assign_lock(host, &adapter->lock);

still b0rked.  The driver shouldn't use scsi_assign_lock which
it's one of the last users of but just use host->host_lock directly
everywhere.
		
 
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html