Re: [PATCH] Add release function to sd for scsi_disk structure

Christoph Hellwig
2003-10-22T16:17:36Z

On Wed, Oct 22, 2003 at 09:08:55AM -0700, Mike Anderson wrote:
> Christoph Hellwig [hch@infradead.org] wrote:
> >
> > This looks like a reasonable bandaid until the block layer is fixed.
> >
>
> Since I do not know the extent of the block layer changes maybe my
> assumption is incorrect, but wouldn't will still need a release of some
> kind to know when it is safe to do a free?

We'll have to see. My assumption would be that freeing any private
data should be fine after ->remove. If that's not going to be guaranteed
we should try to make your patch a bit more generic (e.g. no sd-specific
ktype)