From: Adrian Bunk <bunk@fs.tum.de>
To: Xose Vazquez Perez <xose@wanadoo.es>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [patch] 2.4.23-pre8: link error with both megaraid drivers
Date: Thu, 23 Oct 2003 21:52:24 +0200 [thread overview]
Message-ID: <20031023195223.GI11807@fs.tum.de> (raw)
In-Reply-To: <3F97F35D.30101@wanadoo.es>
On Thu, Oct 23, 2003 at 05:27:25PM +0200, Xose Vazquez Perez wrote:
> Adrian Bunk wrote:
>
> > The patch below fixes this issue by disalllowing the static inclusion of
> > both drivers at the same time.
>
> IMO this patch makes a better job. It only allows one in kernel,
> and it allows two modules at same time.
>...
My patch allows this, too, or what did I miss?
> -thanks-
>
> --- linux/drivers/scsi/Config.in 2003-10-23 16:56:13.000000000 +0200
> +++ new/drivers/scsi/Config.in 2003-10-23 17:00:51.000000000 +0200
> @@ -66,8 +66,14 @@
> dep_tristate 'AdvanSys SCSI support' CONFIG_SCSI_ADVANSYS $CONFIG_SCSI
> dep_tristate 'Always IN2000 SCSI support' CONFIG_SCSI_IN2000 $CONFIG_SCSI
> dep_tristate 'AM53/79C974 PCI SCSI support' CONFIG_SCSI_AM53C974 $CONFIG_SCSI $CONFIG_PCI
> -dep_tristate 'AMI MegaRAID support' CONFIG_SCSI_MEGARAID $CONFIG_SCSI
> -dep_tristate 'AMI MegaRAID2 support' CONFIG_SCSI_MEGARAID2 $CONFIG_SCSI
> +
> +if [ "$CONFIG_SCSI_MEGARAID2" != "y" ]; then
> + dep_tristate 'AMI MegaRAID support' CONFIG_SCSI_MEGARAID $CONFIG_SCSI
> +fi
> +
> +if [ "$CONFIG_SCSI_MEGARAID" != "y" ]; then
> + dep_tristate 'AMI MegaRAID2 support' CONFIG_SCSI_MEGARAID2 $CONFIG_SCSI
> +fi
>
> dep_tristate 'BusLogic SCSI support' CONFIG_SCSI_BUSLOGIC $CONFIG_SCSI
> if [ "$CONFIG_SCSI_BUSLOGIC" != "n" ]; then
The difference between your and my patch is that your patch doesn't
allow one in kernel plus the other one modular.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2003-10-23 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-23 15:27 [patch] 2.4.23-pre8: link error with both megaraid drivers Xose Vazquez Perez
2003-10-23 19:52 ` Adrian Bunk [this message]
2003-10-24 3:27 ` Xose Vazquez Perez
[not found] <Pine.LNX.4.44.0310222116270.1364-100000@logos.cnet>
2003-10-23 14:07 ` Adrian Bunk
2003-10-23 14:18 ` Matthew Wilcox
2003-10-23 19:42 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031023195223.GI11807@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=xose@wanadoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox