From: Patrick Mansfield <patmans@us.ibm.com>
To: Dmitri Katchalov <dmitrik@users.sourceforge.net>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb-devel@lists.sourceforge.net,
linux-scsi@vger.kernel.org
Subject: Re: usb-storage and Sony Handycam
Date: Fri, 7 Nov 2003 22:34:44 -0800 [thread overview]
Message-ID: <20031107223444.A1747@beaverton.ibm.com> (raw)
In-Reply-To: <1068260051.3fac5ad3ea76c@webmail.netregistry.net>; from dmitrik@users.sourceforge.net on Sat, Nov 08, 2003 at 01:54:11PM +1100
On Sat, Nov 08, 2003 at 01:54:11PM +1100, Dmitri Katchalov wrote:
> Well, when I said "ignore babble" I actually did this:
> case -EOVERFLOW:
> - return USB_STOR_XFER_LONG;
> + return USB_STOR_XFER_STALL;
> I agree, it was not a good idea. I only tried it to see what happens.
>
> As I said, my camera works just fine. All I need is a module parameter
> in modprobe.conf (or a new entry in scsi_devinfo.c), no other code changes
> required. I just thought you may be interested in this rather peculiar
> behaviour.
We need to figure out what is different here, and why (based on other
reports for this device) this worked on 2.4 but not on 2.6.
Looking at usb/storage/transport.c, we are not generating the usb
"fake_sense" with your change.
Maybe the failed MODE SENSE had a check condition, but the fake_sense
prevented us from retrieving it?
So the next command sent got a check condition, illegal request.
That still doesn't tell us why the MODE SENSE failed, and why the failure
does not show up with 2.4.
Can you run the variants on MODE SENE via user space SG_IO, and figure out
which ones work?
AFAICT at least three different problems are contributing to the failure:
1) The MODE SENSE seems to work fine in 2.4, but is failing in 2.6. In
2.4, we always send a MODE SENSE page 3f with length 255; in 2.6 we start by
asking for 4 bytes.
2) scsi core ignores host byte errors (DID_ERROR). This means we behave as
if the MODE SENSE worked OK, even though USB tells scsi core that it
failed. Fixing this problem (for another user) caused even worse problems.
3) The next command - TEST UNIT READY - gets a check condition, illegal
request. Maybe the fake sense handling is screwing things up - the device
tells us it sent back more data than we asked for, but it is also trying
to check us.
-- Patrick Mansfield
-------------------------------------------------------
This SF.Net email sponsored by: ApacheCon 2003,
16-19 November in Las Vegas. Learn firsthand the latest
developments in Apache, PHP, Perl, XML, Java, MySQL,
WebDAV, and more! http://www.apachecon.com/
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
next prev parent reply other threads:[~2003-11-08 6:34 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1068207145.3fab8c2988d43@webmail.netregistry.net>
2003-11-07 16:21 ` usb-storage and Sony Handycam Alan Stern
2003-11-07 17:29 ` Patrick Mansfield
2003-11-07 19:49 ` Alan Stern
2003-11-08 2:54 ` Dmitri Katchalov
2003-11-08 6:34 ` Patrick Mansfield [this message]
2003-11-08 13:29 ` Dmitri Katchalov
2003-11-08 16:28 ` Alan Stern
2003-11-08 20:37 ` Patrick Mansfield
2003-11-09 3:47 ` [linux-usb-devel] " Alan Stern
2003-11-09 8:45 ` Dmitri Katchalov
2003-11-10 20:45 ` Patrick Mansfield
2003-11-10 17:59 ` Patrick Mansfield
2003-11-10 18:46 ` Alan Stern
2003-11-10 19:04 ` [linux-usb-devel] " Patrick Mansfield
2003-11-10 19:57 ` Alan Stern
2003-11-10 22:46 ` Sancho Dauskardt
2003-11-18 15:20 ` Unaligned scatter-gather buffers and usb-storage Alan Stern
2003-11-18 22:37 ` Patrick Mansfield
2003-11-19 8:47 ` Jens Axboe
2003-11-19 13:01 ` [linux-usb-devel] " Oliver Neukum
2003-11-19 13:04 ` Jens Axboe
2003-11-19 14:37 ` James Bottomley
2003-11-19 14:39 ` Jens Axboe
2003-11-19 14:58 ` James Bottomley
2003-11-19 15:00 ` [linux-usb-devel] " Jens Axboe
2003-11-19 16:56 ` Kai Makisara
2003-11-19 20:19 ` Jens Axboe
2003-11-19 22:06 ` Kai Makisara
2003-11-20 6:53 ` Jens Axboe
2003-11-20 15:20 ` Alan Stern
2003-11-20 15:30 ` Jens Axboe
2003-11-20 16:09 ` Alan Stern
2003-11-20 16:24 ` Jens Axboe
2003-11-20 16:28 ` [linux-usb-devel] " Oliver Neukum
2003-11-20 19:23 ` Kai Makisara
2003-11-20 17:18 ` Kai Makisara
2003-11-20 19:18 ` [linux-usb-devel] " Kai Mäkisara
2003-11-21 18:03 ` PATCH: (as141) " Alan Stern
2003-11-21 20:07 ` Kai Makisara
2003-12-01 1:30 ` Matthew Dharm
2004-01-05 0:41 ` Matthew Dharm
2004-01-05 10:08 ` Jens Axboe
2004-01-05 21:58 ` PATCH: (as141b) " Alan Stern
2004-01-06 11:28 ` Oliver Neukum
2004-01-06 16:10 ` Alan Stern
2004-02-02 15:51 ` James Bottomley
2004-02-03 15:47 ` Alan Stern
2004-02-03 15:55 ` James Bottomley
2004-02-03 16:02 ` Matthew Wilcox
2003-11-19 15:44 ` Alan Stern
2003-11-19 15:49 ` Jens Axboe
2003-11-19 16:58 ` Alan Stern
2003-11-19 17:03 ` Jens Axboe
2003-11-07 22:09 ` usb-storage and Sony Handycam Alan Stern
2003-11-10 22:21 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031107223444.A1747@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=dmitrik@users.sourceforge.net \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).