From: Patrick Mansfield <patmans@us.ibm.com>
To: Amit Patel <patelamitv@yahoo.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: scsi_report_lun_scan bug?
Date: Mon, 17 Nov 2003 21:52:52 -0800 [thread overview]
Message-ID: <20031117215252.A25366@beaverton.ibm.com> (raw)
In-Reply-To: <20031118024833.7619.qmail@web13006.mail.yahoo.com>; from patelamitv@yahoo.com on Mon, Nov 17, 2003 at 06:48:33PM -0800
On Mon, Nov 17, 2003 at 06:48:33PM -0800, Amit Patel wrote:
> Hi,
>
> I am using 2.6-test9-mm3. I noticed while doing
> scsi_report_lun_scan(scsi_scan.c:891) the data
> returned is assigned(scsi_scan.c:993) to signed char
> array which causes the reported number of luns to be
> huge while calculating num_luns to scan. Is there any
> particular reason to be data is signed or just a bug?
>
> I changed it to unsigned char and it seems to work
> fine. I have attached a diff of scsi_scan.c. Let me
> know if I am missing something.
I don't see why making it signed or unsigned would make any difference.
What values did you see before and after your patch?
It should really be a u8, since it is a pointer to an array of bytes.
(And all the scsi_cmd[]'s should be u8.)
-- Patrick Mansfield
next prev parent reply other threads:[~2003-11-18 5:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-18 2:48 scsi_report_lun_scan bug? Amit Patel
2003-11-18 2:54 ` Matthew Wilcox
2003-11-18 3:10 ` Amit Patel
2003-11-18 5:52 ` Patrick Mansfield [this message]
2003-11-18 7:00 ` Andrew Morton
2003-11-18 7:42 ` Amit Patel
2003-11-20 1:56 ` State Model for scsi device badness Amit Patel
2003-11-20 19:01 ` State Model for scsi device badness PATCH Amit Patel
2003-11-20 19:02 ` James Bottomley
2003-11-21 2:37 ` Mike Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031117215252.A25366@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=patelamitv@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox