From: Patrick Mansfield <patmans@us.ibm.com>
To: Pat LaVarre <p.lavarre@ieee.org>
Cc: dmitrik@users.sourceforge.net, linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@steeleye.com>,
Jens Axboe <axboe@suse.de>
Subject: [PATCH] Don't retry SG_IO (REQ_BLOCK_PC) commands.
Date: Thu, 20 Nov 2003 08:55:55 -0800 [thread overview]
Message-ID: <20031120085555.A20609@beaverton.ibm.com> (raw)
On Thu, Nov 20, 2003 at 08:57:15AM -0700, Pat LaVarre wrote:
> This also could matter. In our kernel code who wrongly thinks we gave
> permission to retry SG_IO? This evidence echoes someone else's - may
sg.c looks OK, Dmitri must be using /dev/sdN. We need this fix, patch
is for the current scsi-bugfixes-2.6:
Don't retry SG_IO (REQ_BLOCK_PC) commands.
===== drivers/scsi/sd.c 1.138 vs edited =====
--- 1.138/drivers/scsi/sd.c Fri Oct 17 16:14:06 2003
+++ edited/drivers/scsi/sd.c Thu Nov 20 08:18:34 2003
@@ -347,9 +347,9 @@
*/
SCpnt->transfersize = sdp->sector_size;
SCpnt->underflow = this_count << 9;
+ SCpnt->allowed = SD_MAX_RETRIES;
queue:
- SCpnt->allowed = SD_MAX_RETRIES;
SCpnt->timeout_per_command = timeout;
/*
next reply other threads:[~2003-11-20 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-20 16:55 Patrick Mansfield [this message]
2003-11-20 18:15 ` [PATCH] Don't retry SG_IO (REQ_BLOCK_PC) commands Mike Anderson
2003-11-20 19:16 ` Jens Axboe
2003-11-20 21:51 ` Patrick Mansfield
2003-11-21 10:17 ` Jens Axboe
2003-11-21 12:48 ` James Bottomley
2003-11-21 14:12 ` James Bottomley
2003-11-22 23:00 ` Andries Brouwer
2003-11-21 16:26 ` Patrick Mansfield
2003-11-21 18:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031120085555.A20609@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=axboe@suse.de \
--cc=dmitrik@users.sourceforge.net \
--cc=linux-scsi@vger.kernel.org \
--cc=p.lavarre@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox