Re: State Model for scsi device badness PATCH

James Bottomley
2003-11-20T19:20:34Z

On Thu, 2003-11-20 at 13:01, Amit Patel wrote:
> I just walked through some of the code and I could
> work around the badness problem by not doing
> get_device if the scsi device is not in running state
> yet. I have attached the patch for scsi_lib.c where I
> do not call get_device if the state is not
> SDEV_RUNNING and similarly do not do put_device if you
> have not done get_device because of the device state.

Ah, I'm sorry, warning light goes off.

The patch is designed to operate on top of Mike Anderson's rework of our
device initialisation code.

http://marc.theaimsgroup.com/?l=linux-scsi&m=106810957502435&w=2

The get_device in the request function causes the badness without this
other patch.

Mike hasn't yet posted an update (hey, this is a hint, Mike) otherwise I
would already have folded it into the bugfixes tree.

James