From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>,
Pete Clements <clem@clem.clem-digital.net>,
Fabio Coatti <cova@ferrara.linux.it>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Christoph Hellwig <hch@lst.de>
Subject: Re: Fix for aic7xxx problems in BK latest
Date: Mon, 24 Nov 2003 08:18:54 +0100 [thread overview]
Message-ID: <20031124071854.GA32490@lst.de> (raw)
In-Reply-To: <1069653204.2066.25.camel@mulgrave>
On Sun, Nov 23, 2003 at 11:53:20PM -0600, James Bottomley wrote:
> It turns out the scsi_device refcounting and list lockdown altered the
> conditions under which scsi_report_bus_reset() works, since it calls
> shost_for_each_device, which now takes the host lock, that lock cannot
> be held while calling the report functions. However, the assumption by
> aic is that it can.
>
> I fixed the problem by using the no lock version of the iterator.
Well, that makes the problem go away but adds races again, the right
fix is to rename you versions with an __ and make the normal versions
take the host_lock around that - we don't actually need the refcounting
here because we just set the two flags so holding the lock over it is
fine.
prev parent reply other threads:[~2003-11-24 7:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-24 5:53 Fix for aic7xxx problems in BK latest James Bottomley
2003-11-24 7:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031124071854.GA32490@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@SteelEye.com \
--cc=clem@clem.clem-digital.net \
--cc=cova@ferrara.linux.it \
--cc=linux-scsi@vger.kernel.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox