public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: "Justin T. Gibbs" <gibbs@scsiguy.com>, linux-scsi@vger.kernel.org
Subject: Re: aic7xxx deadlock in 2.6.0-test10
Date: Mon, 24 Nov 2003 08:13:19 +0000	[thread overview]
Message-ID: <20031124081319.A29562@infradead.org> (raw)
In-Reply-To: <20031123230853.0bc8defb.akpm@osdl.org>; from akpm@osdl.org on Sun, Nov 23, 2003 at 11:08:53PM -0800

On Sun, Nov 23, 2003 at 11:08:53PM -0800, Andrew Morton wrote:
> ahc_linux_register_host() is calling ahc_linux_initialize_scsi_bus() under
> ahc_lock(ahc, &s).  But scsi_report_bus_reset() is taking host->host_lock
> inside shost_for_each_device(), and that is the same (already held) lock.
> 
> 
> This patch gets things going again of course.  Could someone please take a
> look at fixing this for real?
> 
> I'm not sure why this has suddenly started happening actually.

jejb just posted another fix for it on linux-scsi, but in fact your fix
looks better to me, ahc_initialize doesn't need the host_lock because
ahc can't be reached from an other thread yet.


  reply	other threads:[~2003-11-24  8:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-24  7:08 aic7xxx deadlock in 2.6.0-test10 Andrew Morton
2003-11-24  8:13 ` Christoph Hellwig [this message]
2003-11-24 15:08   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031124081319.A29562@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@osdl.org \
    --cc=gibbs@scsiguy.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox