public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* Fw: 2.6.0-test9 kernel oops
@ 2003-11-24  7:10 Andrew Morton
  2003-11-24 15:23 ` James Bottomley
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Andrew Morton @ 2003-11-24  7:10 UTC (permalink / raw)
  To: linux-scsi, Justin T. Gibbs; +Cc: Tomas Kostrian


Can anyone else with an aic7xxx reproduce (and hence fix) this?
/proc/scsi/aic7xxx/0 works happily on my test box.


Begin forwarded message:

Date: Mon, 24 Nov 2003 06:36:32 +0100
From: Tomas Kostrian <kostrian@deepblue.sk>
To: akpm@osdl.org
Subject: 2.6.0-test9 kernel oops


kostrian@test:~$ uname -a
Linux test.[SNIFF].sk 2.6.0-test9 #1 Sun Nov 9 01:35:44 CET 2003 i686
unknown
kostrian@test:~$ ls -la /proc/scsi/aic7xxx/
total 0
dr-xr-xr-x    2 root     root            0 Nov 24 00:06 .
dr-xr-xr-x    4 root     root            0 Nov 24 00:06 ..
-rw-r--r--    1 root     root            0 Nov 24 00:06 0
kostrian@test:~$ cat /proc/scsi/aic7xxx/0
Segmentation fault
kostrian@test:~$ dmesg
.
.
[SNIFF]
.
.
Unable to handle kernel NULL pointer dereference at virtual address
00000120
 printing eip:
c02624d8
*pde = 00000000
Oops: 0000 [#1]
CPU:    0
EIP:    0060:[<c02624d8>]    Not tainted
EFLAGS: 00010286
EIP is at aic7xxx_proc_info+0x1c/0xab4
eax: c02624bc   ebx: c3a63f78   ecx: 00000000   edx: 00000000
esi: 00000400   edi: c3aca000   ebp: c3a63f74   esp: c3a63ef4
s: 007b   es: 007b   ss: 0068
Process cat (pid: 657, threadinfo=c3a62000 task=c5e37350)
Stack: c3a63f78 00000400 c3aca000 c3a63f74 00000000 c03a8054 c012d24b c025139b
       c1187000 c3aca000 c3a63f78 00000000 00000400 00000000 00000000 c6332400
       00000400 c3aca000 c016a508 c3aca000 c3a63f78 00000000 00000400 c3a63f74
Call Trace:
 [<c012d24b>] __alloc_pages+0xa3/0x2dc
 [<c025139b>] proc_scsi_read+0x2b/0x44
 [<c016a508>] proc_file_read+0x10c/0x238
 [<c013fdb5>] vfs_read+0xb5/0xe4
 [<c013ffb5>] sys_read+0x31/0x4c
 [<c0108a53>] syscall_call+0x7/0xb

Code: 83 b9 20 01 00 00 00 75 f1 85 c9 75 2f 0f b7 05 58 00 00 00

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fw: 2.6.0-test9 kernel oops
  2003-11-24  7:10 Fw: 2.6.0-test9 kernel oops Andrew Morton
@ 2003-11-24 15:23 ` James Bottomley
  2003-11-24 15:41   ` Mike Anderson
  2003-11-24 18:56 ` Randy.Dunlap
  2003-11-24 19:46 ` [PATCH] 2.6.0-test9 kernel oops (aic7x_old) Randy.Dunlap
  2 siblings, 1 reply; 5+ messages in thread
From: James Bottomley @ 2003-11-24 15:23 UTC (permalink / raw)
  To: Andrew Morton; +Cc: SCSI Mailing List, Justin T. Gibbs, Tomas Kostrian

On Mon, 2003-11-24 at 01:10, Andrew Morton wrote:
> Can anyone else with an aic7xxx reproduce (and hence fix) this?
> /proc/scsi/aic7xxx/0 works happily on my test box.

Actually (since I managed to dig out an x86 aic7xxx based machine), I've
tried this and not seen the problem...it could be because I've been
testing out with the two SCSI refcount fixes as well...I'll try
stripping them back.

James



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fw: 2.6.0-test9 kernel oops
  2003-11-24 15:23 ` James Bottomley
@ 2003-11-24 15:41   ` Mike Anderson
  0 siblings, 0 replies; 5+ messages in thread
From: Mike Anderson @ 2003-11-24 15:41 UTC (permalink / raw)
  To: James Bottomley
  Cc: Andrew Morton, SCSI Mailing List, Justin T. Gibbs, Tomas Kostrian

James Bottomley [James.Bottomley@steeleye.com] wrote:
> On Mon, 2003-11-24 at 01:10, Andrew Morton wrote:
> > Can anyone else with an aic7xxx reproduce (and hence fix) this?
> > /proc/scsi/aic7xxx/0 works happily on my test box.
> 
> Actually (since I managed to dig out an x86 aic7xxx based machine), I've
> tried this and not seen the problem...it could be because I've been
> testing out with the two SCSI refcount fixes as well...I'll try
> stripping them back.

I tried with just plain test9 and cannot get the error to reproduce. 

Tomas, Can you send the dmesg output of the driver loading.

-andmike
--
Michael Anderson
andmike@us.ibm.com


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fw: 2.6.0-test9 kernel oops
  2003-11-24  7:10 Fw: 2.6.0-test9 kernel oops Andrew Morton
  2003-11-24 15:23 ` James Bottomley
@ 2003-11-24 18:56 ` Randy.Dunlap
  2003-11-24 19:46 ` [PATCH] 2.6.0-test9 kernel oops (aic7x_old) Randy.Dunlap
  2 siblings, 0 replies; 5+ messages in thread
From: Randy.Dunlap @ 2003-11-24 18:56 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-scsi, gibbs, kostrian

On Sun, 23 Nov 2003 23:10:37 -0800 Andrew Morton <akpm@osdl.org> wrote:

| 
| Can anyone else with an aic7xxx reproduce (and hence fix) this?
| /proc/scsi/aic7xxx/0 works happily on my test box.
| 
| 
| Begin forwarded message:
| 
| Date: Mon, 24 Nov 2003 06:36:32 +0100
| From: Tomas Kostrian <kostrian@deepblue.sk>
| To: akpm@osdl.org
| Subject: 2.6.0-test9 kernel oops
| 
| 
| kostrian@test:~$ uname -a
| Linux test.[SNIFF].sk 2.6.0-test9 #1 Sun Nov 9 01:35:44 CET 2003 i686
| unknown
| kostrian@test:~$ ls -la /proc/scsi/aic7xxx/
| total 0
| dr-xr-xr-x    2 root     root            0 Nov 24 00:06 .
| dr-xr-xr-x    4 root     root            0 Nov 24 00:06 ..
| -rw-r--r--    1 root     root            0 Nov 24 00:06 0
| kostrian@test:~$ cat /proc/scsi/aic7xxx/0
| Segmentation fault
| kostrian@test:~$ dmesg
| .
| .
| [SNIFF]
| .
| .
| Unable to handle kernel NULL pointer dereference at virtual address
| 00000120
|  printing eip:
| c02624d8
| *pde = 00000000
| Oops: 0000 [#1]
| CPU:    0
| EIP:    0060:[<c02624d8>]    Not tainted
| EFLAGS: 00010286
| EIP is at aic7xxx_proc_info+0x1c/0xab4
| eax: c02624bc   ebx: c3a63f78   ecx: 00000000   edx: 00000000
| esi: 00000400   edi: c3aca000   ebp: c3a63f74   esp: c3a63ef4
| s: 007b   es: 007b   ss: 0068
| Process cat (pid: 657, threadinfo=c3a62000 task=c5e37350)
| Stack: c3a63f78 00000400 c3aca000 c3a63f74 00000000 c03a8054 c012d24b c025139b
|        c1187000 c3aca000 c3a63f78 00000000 00000400 00000000 00000000 c6332400
|        00000400 c3aca000 c016a508 c3aca000 c3a63f78 00000000 00000400 c3a63f74
| Call Trace:
|  [<c012d24b>] __alloc_pages+0xa3/0x2dc
|  [<c025139b>] proc_scsi_read+0x2b/0x44
|  [<c016a508>] proc_file_read+0x10c/0x238
|  [<c013fdb5>] vfs_read+0xb5/0xe4
|  [<c013ffb5>] sys_read+0x31/0x4c
|  [<c0108a53>] syscall_call+0x7/0xb
| 
| Code: 83 b9 20 01 00 00 00 75 f1 85 c9 75 2f 0f b7 05 58 00 00 00
| -

I can reproduce it (note, this is with aic7xyx_old, not Justin's driver).
I'll see if I can produce a fix or something...

--
~Randy
MOTD:  Always include version info.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] 2.6.0-test9 kernel oops (aic7x_old)
  2003-11-24  7:10 Fw: 2.6.0-test9 kernel oops Andrew Morton
  2003-11-24 15:23 ` James Bottomley
  2003-11-24 18:56 ` Randy.Dunlap
@ 2003-11-24 19:46 ` Randy.Dunlap
  2 siblings, 0 replies; 5+ messages in thread
From: Randy.Dunlap @ 2003-11-24 19:46 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-scsi, kostrian, hch, jejb, torvalds

On Sun, 23 Nov 2003 23:10:37 -0800 Andrew Morton <akpm@osdl.org> wrote:

| 
| Can anyone else with an aic7xxx reproduce (and hence fix) this?
| /proc/scsi/aic7xxx/0 works happily on my test box.
| 
| 
| Unable to handle kernel NULL pointer dereference at virtual address
| 00000120
|  printing eip:
| c02624d8
| *pde = 00000000
| Oops: 0000 [#1]
| CPU:    0
| EIP:    0060:[<c02624d8>]    Not tainted
| EFLAGS: 00010286
| EIP is at aic7xxx_proc_info+0x1c/0xab4
| eax: c02624bc   ebx: c3a63f78   ecx: 00000000   edx: 00000000
| esi: 00000400   edi: c3aca000   ebp: c3a63f74   esp: c3a63ef4
| s: 007b   es: 007b   ss: 0068
| Process cat (pid: 657, threadinfo=c3a62000 task=c5e37350)
| Stack: c3a63f78 00000400 c3aca000 c3a63f74 00000000 c03a8054 c012d24b c025139b
|        c1187000 c3aca000 c3a63f78 00000000 00000400 00000000 00000000 c6332400
|        00000400 c3aca000 c016a508 c3aca000 c3a63f78 00000000 00000400 c3a63f74
| Call Trace:
|  [<c012d24b>] __alloc_pages+0xa3/0x2dc
|  [<c025139b>] proc_scsi_read+0x2b/0x44
|  [<c016a508>] proc_file_read+0x10c/0x238
|  [<c013fdb5>] vfs_read+0xb5/0xe4
|  [<c013ffb5>] sys_read+0x31/0x4c
|  [<c0108a53>] syscall_call+0x7/0xb
| 
| Code: 83 b9 20 01 00 00 00 75 f1 85 c9 75 2f 0f b7 05 58 00 00 00


Patch below (to -test10) fixes it for me.
Please apply.

--
~Randy



description:	repair oops in aic7xxx_old proc_info()
author:		Randy.Dunlap <rddunlap@osdl.org>

diffstat:=
 drivers/scsi/aic7xxx_old/aic7xxx_proc.c |    2 --
 1 files changed, 2 deletions(-)

diff -Naurp ./drivers/scsi/aic7xxx_old/aic7xxx_proc.c~aic7_proc ./drivers/scsi/aic7xxx_old/aic7xxx_proc.c
--- ./drivers/scsi/aic7xxx_old/aic7xxx_proc.c~aic7_proc	2003-11-23 17:32:55.000000000 -0800
+++ ./drivers/scsi/aic7xxx_old/aic7xxx_proc.c	2003-11-24 11:47:16.000000000 -0800
@@ -90,8 +90,6 @@ aic7xxx_proc_info ( struct Scsi_Host *HB
   unsigned char i;
   unsigned char tindex;
 
-  HBAptr = NULL;
-
   for(p=first_aic7xxx; p->host != HBAptr; p=p->next)
     ;
 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2003-11-24 19:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-11-24  7:10 Fw: 2.6.0-test9 kernel oops Andrew Morton
2003-11-24 15:23 ` James Bottomley
2003-11-24 15:41   ` Mike Anderson
2003-11-24 18:56 ` Randy.Dunlap
2003-11-24 19:46 ` [PATCH] 2.6.0-test9 kernel oops (aic7x_old) Randy.Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox