Re: [announce] scsi_id release 0.2

[Olaf Hering <olh@suse.de>]

 On Sun, Dec 07, Patrick Mansfield wrote:

> On Sun, Dec 07, 2003 at 04:38:02PM +0100, Olaf Hering wrote:
> >  On Fri, Dec 05, Patrick Mansfield wrote:
> > 
> > > Version 0.2 of scsi_id is available at:
> > > 
> > > http://www-124.ibm.com/storageio/scsi_id/scsi_id-0.2.tar.gz
> > 
> > What is $(DEBUG)? It is used by klibc and replaced by true/false.
> 
> I use it to compile with -g. 
> 
> i.e.:
> 	
> 	# make DEBUG=-g 
> 	cc -DSCSI_ID_VERSION=\"0.2\" -g -Wall   -c -o scsi_id.o scsi_id.c
> 	cc -DSCSI_ID_VERSION=\"0.2\" -g -Wall   -c -o scsi_serial.o scsi_serial.c
> 	cc  -o scsi_id  scsi_id.o scsi_serial.o  -lsysfs  
> 
> The udev DEBUG value does not get passed down to the extras, so the
> scsi_id build under udev should be OK.

It does. make EXTRAS=extras/scsi_id will pass DEBUG=false/true if
defined.

> Is it breaking your build? If so I'll just remove it.

Yes, just try to build a udev debug binary.

I need also this patch because gcc decides that a printf("\n"); could be
done with a putchar, which is not defined for some reasons.

--- extras/scsi_id/Makefile.orig        2003-12-07 15:05:33.000000000 +0100
+++ extras/scsi_id/Makefile     2003-12-07 15:14:09.000000000 +0100
@@ -27,7 +27,7 @@ INSTALL_DATA  = ${INSTALL} -m 644
 # Note some of the variables used here are set when built under udev, and
 # otherwise might not be set.

-override CFLAGS+=-DSCSI_ID_VERSION=\"$(SCSI_ID_VERSION)\" $(DEBUG) -Wall
+override CFLAGS+=-DSCSI_ID_VERSION=\"$(SCSI_ID_VERSION)\" -Wall -fno-builtin

 PROG=scsi_id
 SYSFS=-lsysfs


Greg has the new scsi_id already merged into the bk repo.


-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html