public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Frank Borich <Frank_Borich@us.xyratex.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH] 2.4.23
Date: Sun, 28 Dec 2003 20:10:20 +0000	[thread overview]
Message-ID: <20031228201020.C22668@infradead.org> (raw)
In-Reply-To: <47F3C2BE74738E4683574107469DFA201EE1D8@XYUSEX01.xyus.xyratex.com>; from Frank_Borich@us.xyratex.com on Wed, Dec 17, 2003 at 08:13:40AM -0800

On Wed, Dec 17, 2003 at 08:13:40AM -0800, Frank Borich wrote:
> Hi All,
> 
> My name is Frank Borich, representing Xyratex International
> (http://www.xyratex.com).  We design, and manufacture Data Storage
> Subsystems.  During integration testing, we discovered that a patch to
> scsi_scan.c is required (2.4.x kernels only), in order to set the
> BLIST_SPARSELUN flag for our subsystems.  This flag adds support for
> non-contiguous lun numbering.  We are unable to use the already
> implemented "device_list" to set flags for our subsystems.  This is due
> to the fact that we sell only to OEMs, and vendor name will change.
> Rather than submit a separate patch for each branded subsystem we can
> look elsewhere in the SCSI inquiry data, and set the flag accordingly.
> The logic below, is executed once the end of the device_list is reached.
> When the end of the table is reached, a memcmp is issued to look for a
> particular string located at offset 96.  If the string is found, the
> flag BLIST_SPARSELUN is returned.  Below is a patch for the SCSI driver
> (scsi_scan.c). 

I'm not too happy about the form of this patch. Could you cook up one
for 2.6.0 that adds a function pointer to poke at the inquiry data
to the blacklist?  We could backport it to 2.4 later.


  reply	other threads:[~2003-12-28 20:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-17 16:13 [PATCH] 2.4.23 Frank Borich
2003-12-28 20:10 ` Christoph Hellwig [this message]
2003-12-28 20:45   ` James Bottomley
  -- strict thread matches above, loose matches on Subject: below --
2003-12-31 15:14 Frank Borich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031228201020.C22668@infradead.org \
    --to=hch@infradead.org \
    --cc=Frank_Borich@us.xyratex.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox